Bug 109617 - [PropertiesView] Allow PropertySheetPage to be subclassed
Summary: [PropertiesView] Allow PropertySheetPage to be subclassed
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: api
Depends on: 382378
Blocks: 287684
  Show dependency tree
 
Reported: 2005-09-15 10:36 EDT by Nick Edgar CLA
Modified: 2021-05-31 12:27 EDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Edgar CLA 2005-09-15 10:36:12 EDT
3.1

As per bug 1883 comment 45, in 3.1 we allowed PropertySheetPage's sorter to be
overridden by subclassing, but the Javadoc for it still says:

 * This class may be instantiated; it is not intended to be subclassed.

We should remove this, and clarify that it can be subclassed and what the
subclasser responsibilities are.  Need to ensure that the existing protected API
makes sense, and consider whether other methods should be opened up.
Comment 1 Alexander Nyßen CLA 2011-02-02 05:44:54 EST
There are other use cases than the sorter that require to extend PropertySheetPage. In our case (GEF) as well as in all generated EMF editors its that custom undo/redo actions need to be registered (see bug #287684). As such I would propose to open PropertySheetPage for extension (as indicated by the summary).
Comment 2 Eclipse Genie CLA 2015-03-31 16:27:36 EDT
New Gerrit change created: https://git.eclipse.org/r/44951
Comment 3 Eclipse Genie CLA 2021-05-31 12:27:23 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.