Bug 109166 - Provide a hook to capture copy event
Summary: Provide a hook to capture copy event
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Resources (show other bugs)
Version: 3.0.2   Edit
Hardware: PC Windows XP
: P3 enhancement with 18 votes (vote)
Target Milestone: ---   Edit
Assignee: Platform-Resources-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 24263 169592 318430 (view as bug list)
Depends on:
Blocks: 33924 310278
  Show dependency tree
 
Reported: 2005-09-09 11:33 EDT by Mark Phippard CLA
Modified: 2013-10-18 10:10 EDT (History)
25 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Phippard CLA 2005-09-09 11:33:17 EDT
Team providers, at least Subversion, need to be able to capture the copy event
just as much as they need to capture the move event.  This is especially true
for folders.  Subversion stores metadata in a hidden folder.  When you copy a
folder, that metadata is copied with it.  If the target of the copy is a
Subversion working copy this leads to corruption.  If the target is the general
file system it leads to unwanted files.

Ideally, we would like to capture the copy event, as we do the move event, so
that we could run the Subversion copy or export process.  This would allow the
copy to be performed correctly.
Comment 1 John Arthorne CLA 2005-09-30 14:16:33 EDT
*** Bug 24263 has been marked as a duplicate of this bug. ***
Comment 2 John Arthorne CLA 2008-01-04 11:54:04 EST
*** Bug 169592 has been marked as a duplicate of this bug. ***
Comment 3 Francis Upton IV CLA 2008-02-01 14:34:58 EST
Please see bug 217489 which has a patch to provide COPIED_FROM on the IResourceDelta.  This might be helpful to either directly use, or as a basis for extending the Team notification hook.
Comment 4 Gunnar Wagenknecht CLA 2008-02-01 14:42:32 EST
I'm not sure if bug 217489 is necessary here. At least in case of Subversion it replaces the whole copy operation and does the copy on its own (like with move) to that the Resources API just need to send out the notifications.
Comment 5 John Arthorne CLA 2008-02-01 15:27:27 EST
Yep, this bug is about the ability to override/re-implement the copy behaviour. A post-change event isn't sufficient.
Comment 6 Szymon Brandys CLA 2008-04-03 09:01:10 EDT
(In reply to comment #5)
> Yep, this bug is about the ability to override/re-implement the copy behaviour.
> A post-change event isn't sufficient.

So this bug is really about the copy hook mechanism similar to the move/delete one, right? 
Comment 7 thomas menzel CLA 2009-12-15 07:04:27 EST
hi folks,

how about getting this and the related bugs finally done in 3.6?
Comment 8 Szymon Brandys CLA 2009-12-15 08:57:53 EST
Hi Thomas. Looking at comments 4, 5 and 6, it looks like this bug doesn't depend on bug 217489. We don't plan to address it during 3.6, however help and contributions are welcome. I will find time to review Francis' patch at bug 217489 but that's all I can promise right now.
Comment 9 Igor Burilo CLA 2010-07-01 03:40:31 EDT
*** Bug 318430 has been marked as a duplicate of this bug. ***
Comment 10 Igor Burilo CLA 2010-07-01 03:42:26 EDT
Are there any plans for this problem?
Comment 11 Szymon Brandys CLA 2010-07-01 05:03:45 EDT
(In reply to comment #10)
> Are there any plans for this problem?
I will help with this enhancement, if someone from the community is planning to work on it. I guess that you or someone else started hacking the code. So please share your work and I'll comment on it.
Comment 12 Mauro Molinari CLA 2011-04-14 09:37:34 EDT
Any news on this? It has been opened in 2005 (!!!) and it's still blocking bug #310278, a major Subversive bug that leads to corruption of local data. Why isn't this considered?
Comment 13 Szymon Brandys CLA 2011-04-14 10:16:03 EDT
(In reply to comment #12)
> Any news on this? It has been opened in 2005 (!!!) and it's still blocking bug
> #310278, a major Subversive bug that leads to corruption of local data. Why
> isn't this considered?

See commet 11: "I will help with this enhancement, if someone from the community is planning to work on it. I guess that you or someone else started hacking the code. So please share your work and I'll comment on it."
Comment 14 Jörg Thönnes CLA 2011-04-15 03:20:57 EDT
(In reply to comment #13)
> (In reply to comment #12)
> > Any news on this? It has been opened in 2005 (!!!) and it's still blocking bug
> > #310278, a major Subversive bug that leads to corruption of local data. Why
> > isn't this considered?
> 
> See comment 11: "I will help with this enhancement, if someone from the community
> is planning to work on it. I guess that you or someone else started hacking the
> code. So please share your work and I'll comment on it."

Alexander, do you have any plans to supply a patch to the Eclipse core team?
Your Polish neighbors are looking forward to review it... :-)

Cheers, Jörg
Comment 15 Mauro Molinari CLA 2011-04-15 03:33:43 EDT
(In reply to comment #13)
> See commet 11: "I will help with this enhancement, if someone from the
> community is planning to work on it. I guess that you or someone else started
> hacking the code. So please share your work and I'll comment on it."

Hi Szymon, 
I read your comment, however my question is then another: isn't there any plan by the Eclipse Platform team to address such important enhancement requests like this (with 16 votes, lots of CCs, important blocked bugs, opened since 2005, etc.) if no one from the community is able to step in and help?

I know it could sound false, but I would certainly happily help if I could, however I don't know anything about the development of Eclipse and I'm a phase of my life in which I don't have enough time to spend on this, unfortunately.
Comment 16 Alexander Gurov CLA 2011-04-15 06:25:18 EDT
(In reply to comment #14)
> Alexander, do you have any plans to supply a patch to the Eclipse core team?
> Your Polish neighbors are looking forward to review it... :-)
> 
> Cheers, Jörg

Yes, indeed, this is in my plans for quite some time, but I still have my hands full with many other tasks and because there is a way to avoid the situation using "Team->Copy To..." action the problem itself is not a blocker. That is why I will take on this task as soon as I've finished with other important matters.
Comment 17 Davide Cavestro CLA 2011-11-30 03:35:40 EST
Hey guys,
Any news? This is a really serious bug. It's been ages since this bug has been assigned and six months have passed since Comment 16.

Moreover, if you want to copy a gwt module you have no workaround at all. It always ends up with a partial copy (comprising wrong .svn metadata) and a failure, both using copy/paste and using Team|Copy to (the latter would be insufficient in any case, as it does not rename the java file contents to reflect the new packaging)
Comment 18 Alexander Gurov CLA 2011-11-30 04:20:57 EST
(In reply to comment #17)
Unfortunately there is no progress from my side with creating a patch, I have my hands full all the time and I've no estimate for when I could do it in the future too.
Comment 19 Szymon Brandys CLA 2011-11-30 05:33:08 EST
(In reply to comment #18)
> (In reply to comment #17)
> Unfortunately there is no progress from my side with creating a patch, I have
> my hands full all the time and I've no estimate for when I could do it in the
> future too.

Platform Workspace team does not plan to work on this for the Juno release. If you really need it, please provide a high quality patch with tests.
Comment 20 thomas menzel CLA 2011-11-30 07:45:44 EST
with the new WC metadata format (just one .svn @ the root of the WC) i find that this is much less of a problem now.

so, maybe just upgrading to SVN 1.7 will do the trick.
Comment 21 thomas menzel CLA 2011-11-30 07:46:47 EST
(In reply to comment #20)
> with the new WC metadata format (just one .svn @ the root of the WC) i find
> that this is much less of a problem now.
> 
> so, maybe just upgrading to SVN 1.7 will do the trick.

PS: i use tigris' subversive though
Comment 22 Alexander Gurov CLA 2011-11-30 07:51:29 EST
(In reply to comment #21)
Thank you for your comment it seems SVN 1.7 working copy format is really useful to solve the issue too. 

P.S.
Subversive does not support SVN 1.7 yet (it is in development right now).
Comment 23 Mauro Molinari CLA 2011-11-30 08:21:26 EST
I know the SVN 1.7 API solves the problem, but the problem still exists.

First of all, Subversive, the "official" Eclipse plugin for Subversion access (and part of the Indigo release train) is not yet compatible with the SVN 1.7 API.
Secondly, this bug is about a problem (the lack of a hook for the copy event) which is not strictly speaking just a Subversion integration problem.
And lastly, yes, there are still a lot of users of Subversion pre-1.7 clients.

If you look at the bugs this is blocking, there's also bug #33924 (reported in 2003). That also references bug #217489, which has had a patch since February 2008, never checked in. May that patch be enough for the blocked bugs to be fixed?
Comment 24 Michael Valenta CLA 2011-11-30 08:44:32 EST
It is possible with the current EFS support in the Eclipse Platform for a repository provider to track copy events by wrapping projects shared with their repository with their own EFS. This is what RTC/Jazz SCM does. There are some complications due to minor bugs in the Platform or in clients that reference project resources improperly through the EFS but it works well for the most part. I'm not sure if there is any benefit in providing addition support through deltas or the move/delete hook. A better approach may be to have the SVN providers adopt this approach and deal with any bugs encountered.

P.S. Many of the bugs we encountered in Eclipse have already been fixed in Eclipse but RTC ships on an older version of Eclipse.