Bug 108251 - "OK" should be enabled when type a valid date time value for date type parameter when preview
Summary: "OK" should be enabled when type a valid date time value for date type parame...
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: BIRT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 2.0.0 Final   Edit
Assignee: Jun Zhai CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-29 05:46 EDT by Hongxia Wang CLA
Modified: 2006-01-05 22:28 EST (History)
1 user (show)

See Also:

Attachments
test report (40.03 KB, application/octet-stream)
2005-08-29 05:48 EDT, Hongxia Wang CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hongxia Wang CLA 2005-08-29 05:46:30 EDT 
decription:
"OK" should be enabled when type a valid date time value for date type 
parameter

steps to reproduce:
1. new a datetime type parameter
2. set its display type as edit box
3. preview the report 
4. Input parameter box pops up
5. Type "10/03/2001 10:05:30 AM" in parameter value box 

actual result:
"OK" button is still disabled

expected result:
"OK" should be enabled when type a valid date time value for date type 
parameter
Comment 1 Hongxia Wang CLA 2005-08-29 05:48:22 EDT 
Created attachment 26583 [details]
test report 

test report
Comment 2 Wang Qiangsheng CLA 2005-12-21 01:33:31 EST 
I trace the code of InputParameterDialog and find the reasone of this issue.
Plese check the code on line 868-869.
The original code is 			
ReportParameterConverter converter = new ReportParameterConverter( parameter.getFormat( ),Locale.getDefault( ) );
But the saved date value is local independency.
I tried following code, 
ReportParameterConverter converter = new ReportParameterConverter( parameter.getFormat( ),Locale.US );
It's working.
Could you please review this code?
Comment 3 Wenbin He CLA 2005-12-22 14:43:31 EST 
Currently the default valued stored in the report design is locale dependant. This is a serious bug needed to be fixed. I upgrade its serverity to major.
Comment 4 Wenbin He CLA 2005-12-29 01:55:19 EST 
A proper fix for this issue is to store locale independent values for all parameter values including default values. Before viewer make this change, we need to make sure that model has changed the parameter's default value's type to String from expression.
Comment 5 Jun Zhai CLA 2006-01-04 22:36:48 EST 
fixed
Comment 6 Arto Laurila CLA 2006-01-05 22:28:38 EST 
Verified in build 20060106.