Bug 108078 - [Patch] Apply patch forces me to save all files
Summary: [Patch] Apply patch forces me to save all files
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Platform-Compare-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: bugday
Depends on:
Blocks:
 
Reported: 2005-08-26 02:52 EDT by Dani Megert CLA
Modified: 2021-03-18 15:07 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2005-08-26 02:52:25 EDT
R3.1

AFAIK the patch file contains the information about which files will be touched
and hence I cannot understand why I have to save all my files in order to be
allowed to apply that patch.

NOTE: I cannot even veto the save and continue.
Comment 1 Remy Suen CLA 2007-12-30 09:55:38 EST
This doesn't seem to be a problem anymore as the dialog can now be dismissed.
Comment 2 Tomasz Zarna CLA 2008-01-02 08:39:01 EST
Remy, if you refer to the "Save Resources" dialog, it's true that it can be canceled but it's not doing it exactly the way we would like it to (see bug 208022). Also, if I understood Daniel correctly, he claimed about the fact that he's asked to save _all_ dirty resources.

I think the dialog should be either changed to look more like the "Save Modified
Resources" dialog which pops out prior refactoring (lists resources that need to saved before proceeding) or we could uncheck resources which are not included in the patch (on the modified resources list in the current dialog).
Comment 3 Dani Megert CLA 2008-01-07 10:01:25 EST
I would expect that I am only asked to save files that are indeed part of the patch. Applying a patch is different from a refactoring as you already know upfront which files will be modified (while this list isn't known when you start a refactoring) i.e. only ask to save dirty files that are part of the patch as the other dirty files are irrelevant for this operation.
Comment 4 Eclipse Genie CLA 2019-03-27 17:57:46 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 5 Dani Megert CLA 2019-03-28 06:30:26 EDT
This is still broken in 4.11.
Comment 6 Eclipse Genie CLA 2021-03-18 15:07:45 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.