Community
Participate
Working Groups
Could the following two constants in Widget.java be changed to something smaller? /* Default widths for widgets */ static final int DEFAULT_WIDTH = 64; static final int DEFAULT_HEIGHT = 64; Anything less than or equal to 16 would work for us, 0 would be OK too. I have run our tests (JFace, UI, RCP) and they run fine when the constants are 0. Background: When you write an RCP app and enable the cool bar, the cool bar will initially be empty, but 64x64 pixels in size. On Windows, you cannot see the border of the empty coolbar so the user gets a big empty space at the top of their window and might be confused. See also Bug 70049, where the same problem occurs in an RCP application that starts off with no open perspective and thus no cool bar items.
Created attachment 25072 [details] Snippet that shows the empty coolbar with a size of 64x64 pixels
Created attachment 25073 [details] screenshot of the snippet running
We just need to decide what the defaults are for each subclass of Composite and put the code on every platform.
What happened? This one is pretty easy. We just need to figure out the defaults for each kind of widget.
Any status on this defect? Our product has dependency on bug #70049 which is waiting on this fix. We need this fix in 3.2.
CAR tells me that the fix is easy if we only fix CoolBar (which is what they are asking). +1 to fix CoolBar only.
McQ, we have the fix ready and waiting...
Since the fix is ready, may I ask when it's going to be in the build?
please attach a patch that describes the change.
I've currently got the change implemented on each platform (i.e. on 4 different machines), so it's easier to describe the change than to create a patch. All platforms are the same change: 1) Add the following 2 new constants to CoolBar class: static final int DEFAULT_COOLBAR_WIDTH = 0; static final int DEFAULT_COOLBAR_HEIGHT = 0; 2) In CoolBar computeSize method (which currently uses DEFAULT_WIDTH and DEFAULT_HEIGHT from Control on all platforms if there are no children), - change DEFAULT_WIDTH to DEFAULT_COOLBAR_WIDTH and - change DEFAULT_HEIGHT to DEFAULT_COOLBAR_HEIGHT. Tested on all platforms.
Re comment 8, we need the approval of 2 team leads in order to put any code change in at this point.
+1
Thanks, McQ. Fixed in HEAD > 20060503. This will be in eclipse 3.2RC3.
*** Bug 85261 has been marked as a duplicate of this bug. ***
