Community
Participate
Working Groups
It is necessary to use the deprecated CTabFolderListener via a strongly discouraged cast to enable Close on tabs in a MultiPageEditorPart. These problems could be avoided if the MultiPageEditorPart createContainer method at least had a call-back for additional style bits. This and many other problems could be avoided if MultiPageEditorPart implemented IMultiPageEditorPart.
Not a regression: MultiPageEditorPart never supported CLOSE style. Also, I don't see how defining an IMultiPageEditorPart interface would help here.
Note to self: Ed needs to use CTabFolderListener instead of CTabFolderListener2 because addCTabFolderListener sets the showClose flag. There's no way currently for a subclass of MultiPageEditorPart to set the style bits of either the folder or its items. The problem is that the applicable style bits are a function of which control is used, which we're trying to hide here.
An IMultiPageEditorPart interface would certainly help, becuase there is always the option of a total copy and re-edit. MultiPageEditorPart isn't so massive that it can't be re-implemented. In particular, it would be nice to mix-in IMultiPageEditorPart to a generic edit part that could be used either single page or multi-page. At present the compulsary inheritance from MultiPageEditorPart to exploit the special instanceof tests makes such sharing very hard. [Of course once the probably only two methods added by IMultiPageEditorPart are exposed, they could be put directly into IEditorPart.]
Which instanceof checks are you referring to? Other than the one discussed in bug 103379, the workbench proper should not be doing any special cases for MultiPageEditorPart. You should already be able to copy/modify it (and MultiPageEditorSite and MultiPageEditorActionBarContributor) for your purposes.
MultiPageEditorActionBarContributor line 47 and so also FormEditor line 599 MultiPageEditorPart line 509
So ref 1 and 3 are within the MultiPageEditorPart implementation. If you copied and modified it to use different controls or styles, you would copy/modify those other types too. For ref 2, FormEditor is a subclass of MultiPageEditorPart so it is strongly coupled. If your editor was a form editor, you could not get a different control or style without copying FormEditor too (yuck). But having an interface wouldn't help here either.
There are currently no plans to work on this feature. PW
Changes requested on bug 193523
*** Bug 270340 has been marked as a duplicate of this bug. ***
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
