Bug 101468 - [Workbench] Incorrect doctype line in package.html files
Summary: [Workbench] Incorrect doctype line in package.html files
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: All All
: P3 trivial (vote)
Target Milestone: 3.4   Edit
Assignee: Tod Creasey CLA
QA Contact:
URL:
Whiteboard: hasPatch
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2005-06-23 11:16 EDT by Billy Biggs CLA
Modified: 2007-08-07 13:31 EDT (History)
1 user (show)

See Also:


Attachments
Patch to jface (9.57 KB, patch)
2005-06-23 11:17 EDT, Billy Biggs CLA
no flags Details | Diff
Patch to ui.workbench (16.12 KB, patch)
2005-06-23 11:17 EDT, Billy Biggs CLA
no flags Details | Diff
Patch to ui.ide (6.89 KB, patch)
2005-06-23 11:19 EDT, Billy Biggs CLA
no flags Details | Diff
Patch to org.eclipse.ui (647 bytes, patch)
2005-06-23 11:20 EDT, Billy Biggs CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Billy Biggs CLA 2005-06-23 11:16:43 EDT
The <!DOCTYPE> line at the top of the package.html files in the UI plugins is
incorrect.  This line is case sensitive.  Patches attached.
Comment 1 Billy Biggs CLA 2005-06-23 11:17:10 EDT
Created attachment 23860 [details]
Patch to jface
Comment 2 Billy Biggs CLA 2005-06-23 11:17:28 EDT
Created attachment 23862 [details]
Patch to ui.workbench
Comment 3 Billy Biggs CLA 2005-06-23 11:19:06 EDT
Created attachment 23863 [details]
Patch to ui.ide
Comment 4 Billy Biggs CLA 2005-06-23 11:20:14 EDT
Created attachment 23865 [details]
Patch to org.eclipse.ui

The buildnotes has the same problem.  This patch fixes that.
Comment 5 Kim Horne CLA 2005-06-23 12:15:19 EDT
Not sure if we want to do this for 3.1 or not.
Comment 6 Tod Creasey CLA 2005-06-23 13:17:37 EDT
No I don't think we do. Too much too late.
Comment 7 Michael Van Meekeren CLA 2005-06-23 14:11:27 EDT
Billy what problems do you see because of this?
Comment 8 Billy Biggs CLA 2005-06-23 14:18:55 EDT
It just means that you can't validate the HTML, and although we're asking for it
to be interpreted as 4.01 Transitional, the browser will ignore that and use
whatever its default is.  Since there is no interesting HTML in these pages, I
can't see anything bad happening from having the doctype be wrong, it just means
I can't run an HTML validator on it.
Comment 9 Tod Creasey CLA 2007-06-27 09:56:57 EDT
Patch released for build >20070627. Thanks B-Roc.
Comment 10 Tod Creasey CLA 2007-08-07 13:31:33 EDT
Verified in  I20070807-0010