Bug 100993 - [EditorMgmt][Presentations] Regression: Editor tabs do not remember order or active tab after restarting Eclipse
Summary: [EditorMgmt][Presentations] Regression: Editor tabs do not remember order or ...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2   Edit
Assignee: Shaun Skelton CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks:
 
Reported: 2005-06-20 20:25 EDT by Ron Baldwin CLA
Modified: 2006-04-21 16:01 EDT (History)
4 users (show)

See Also:

Attachments
Changes to PresentablePartFolder#insert(IPresentablePart, int) (877 bytes, patch)
2006-04-21 15:08 EDT, Shaun Skelton CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ron Baldwin CLA 2005-06-20 20:25:36 EDT 
Editor tab order is not restored after closing and reopening Eclipse.

1. Open a few editors such that all tabs are completely visible.  
2. Drag tabs to put in a specific order.  
3. Close and reopen Eclipse.
4. Note that tabs are not in the order they were in when you closed Eclipse.
Comment 1 Kim Horne CLA 2005-06-21 07:50:46 EDT 
Regression with regard to what version?  I was under the impression this was the behaviour in 3.0.
Comment 2 Michael Van Meekeren CLA 2005-06-21 08:56:44 EDT 
Yes this used to work in 3.0.2.
Comment 3 Ron Baldwin CLA 2005-06-21 10:55:46 EDT 
If memory serves correctly, this worked in at least one of the 3.1 milestones. 
I'll try to check this later today (going to have to go redownload some old
milestone builds).
Comment 4 Ron Baldwin CLA 2005-06-21 19:00:32 EDT 
Ok, I've tried 3.0.2 as well as the first few 3.1 milestones.  In 3.0.2 it
definitely remembers the order you place the tabs in (as well as remembering the
active tab, I updated the bug summary to reflect this).  In all the 3.1
milestones I tried it didn't work.  Specifically in milestone 1 I tried to
figure out what it was doing, but it wasn't being consistent in any way I could
determine.
Comment 5 Ron Baldwin CLA 2005-06-23 11:09:01 EDT 
Is a fix for this regression likely to make it for 3.1?
Comment 6 Douglas Pollock CLA 2005-06-23 11:14:58 EDT 
No, it will not make it into 3.1.
Comment 7 Markus Keller CLA 2006-03-10 05:51:28 EST 
Could you try to fix this regression for 3.2? It's really annoying to lose editor tab state when I have to restart eclipse. It destroys my mental model.
Comment 8 Michael Van Meekeren CLA 2006-03-21 16:37:55 EST 
this is a critical bug that used to work.  Shaun could you start by finding out when this broke and then investigating what happened.
Comment 9 Shaun Skelton CLA 2006-04-21 15:08:11 EDT 
Created attachment 39207 [details]
Changes to PresentablePartFolder#insert(IPresentablePart, int)

Normally if a part already exists in the folder, insert is short circuited with
a call to return. This change will add a check to see if the part should be
moved before returning.
Comment 10 Shaun Skelton CLA 2006-04-21 15:09:19 EDT 
Work also being done in this area by Paul on bug 137527
Comment 11 Michael Van Meekeren CLA 2006-04-21 16:01:06 EDT 
applied the patch, tests were run, committed to HEAD