Bug 100040 - Slowdown between 3.1 RC1 and N20050602 due to change to ImageList
Summary: Slowdown between 3.1 RC1 and N20050602 due to change to ImageList
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 3.1 RC3   Edit
Assignee: Felipe Heidrich CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2005-06-14 14:19 EDT by Nick Edgar CLA
Modified: 2005-06-17 14:49 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Edgar CLA 2005-06-14 14:19:10 EDT 
build N20050602

Several of the UI performance tests got slower between RC1 and N20050602, on
Windows.

I tried running one of them, the OpenCloseWindowTest on N20050602, and also with
N20050602+RC1's SWT.
Here are the numbers (on Win2K):

N20050602:
testOpenCloseWindows:org.eclipse.debug.ui.DebugPerspective
  Elapsed Process: 844 ms
  Elapsed Process: 828 ms
  Elapsed Process: 854 ms
  average: 842

N20050602 with SWT from RC1 (I20050527-1300):
testOpenCloseWindows:org.eclipse.debug.ui.DebugPerspective
  Elapsed Process: 751 ms
  Elapsed Process: 757 ms
  Elapsed Process: 731 ms
  average: 746ms

increase: 96 over 746 = 13% slower

I've only included the times for the debug perspective.  The other perspectives
showed less of a change, and seemed to correlate with the numer of icons (either
in the menus or toolbars or both).  The debug perspective has the most icons.

I'm suspicious of the ImageList change to always specify OS.ILC_MIRROR.

I'll see if unwinding that single change makes a difference.
Comment 1 Nick Edgar CLA 2005-06-14 14:19:22 EDT 
Tried again with just the ImageList change (based off of SWT in RC1).
This represents the change from v1.23 to v1.24 of ImageList (under win32).

Without ImageList change (v1.23, no OS.ILC_MIRROR flag): 687, 704, 720
  average: 704

With ImageList change (v1.24, with OS.ILC_MIRROR flag): 824, 848, 827
  average: 833

delta: 129 / 704 = 18% slower
Comment 2 Nick Edgar CLA 2005-06-14 14:20:01 EDT 
Please consider for RC3.
Comment 3 Michael Van Meekeren CLA 2005-06-14 14:21:55 EDT 
+1 this affects many UI performance tests.
Comment 4 Steve Northover CLA 2005-06-14 14:57:31 EDT 
FH to fix.  As soon as the code is ready, we need to confirm with Nick that 
the regression has gone away.
Comment 5 Felipe Heidrich CLA 2005-06-14 15:24:00 EDT 
Nick, I have the code ready, can you help me to set up the performance tests ?
Comment 6 Felipe Heidrich CLA 2005-06-15 11:41:25 EDT 
fixed in HEAD > 20050615
Comment 7 Felipe Heidrich CLA 2005-06-17 14:41:33 EDT 
Nick, can you double check if the result of the performance test are back to 
normal.  Thanks

I checked:
http://fullmoon/downloads/drops/I20050617-0010/performance/org.eclipse.ui.php?
It looked fine to me.
Comment 8 Nick Edgar CLA 2005-06-17 14:49:56 EDT 
Yes, confirmed.