Bug 10001 - [PropertiesView] PropertySheetViewer.updateChildrenOf and updateEntry don't handle changes correctly
Summary: [PropertiesView] PropertySheetViewer.updateChildrenOf and updateEntry don't ...
Status: RESOLVED INVALID
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: investigate, needinfo
: 24181 (view as bug list)
Depends on:
Blocks:
 
Reported: 2002-02-19 11:12 EST by Richard Kulp CLA
Modified: 2009-08-30 02:11 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Kulp CLA 2002-02-19 11:12:43 EST
PropertySheetViewer.updateEntry() has a specific check for getting the image, 
and if the image is null, it will NOT set that into the item. This causes a 
problem. If the entry is being updated from having an image to not having an 
image, the old image stays there. The image being null is a valid setting and 
should be set through so that the entry no longer has an image.

PropertySheetViewer.updateChildrenOf(). If an entry was expanded and had 
children, and if the update indicates there are now no children, the entry is 
still marked as expanded. This doesn't cause a problem until the entry is 
updated again to have children, it is still marked as expanded.

The reason these have shown up is because it is very expensive to always use 
new PropertySheetEntrys when changing input. Deleting is especially expensive, 
it is very slow and very visible to the user when there are a lot of entries 
being deleted. So we were trying to reuse the PropertySheetEntries when the 
input changes. The above problems showed up because the entry was being reused 
but was referring to a different input. So the keeping the old image and the 
old expansion state are inappropriate.

Thanks.
Comment 1 Kevin Haaland CLA 2002-05-01 17:02:07 EDT
No plans to change current 2.0 behavior. 
Comment 2 Randy Giffen CLA 2002-08-09 12:50:36 EDT
Reopen to investigate
Comment 3 Debbie Wilson CLA 2003-05-26 15:44:48 EDT
*** Bug 24181 has been marked as a duplicate of this bug. ***
Comment 4 Tod Creasey CLA 2006-06-22 08:19:55 EDT
There is currently no plan to work on this
Comment 5 Denis Roy CLA 2009-08-30 02:11:38 EDT
As of now 'LATER' and 'REMIND' resolutions are no longer supported.
Please reopen this bug if it is still valid for you.