Summary: | [autobuild] Random startup issues | ||
---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Andrey Loskutov <loskutov> |
Component: | Resources | Assignee: | Jörg Kubitz <jkubitz-eclipse> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | major | ||
Priority: | P3 | CC: | jkubitz-eclipse, Lars.Vogel, sravankumarl |
Version: | 4.23 | Keywords: | regression |
Target Milestone: | 4.23 M3 | ||
Hardware: | PC | ||
OS: | All | ||
See Also: |
https://bugs.eclipse.org/bugs/show_bug.cgi?id=578640 https://git.eclipse.org/r/c/platform/eclipse.platform.resources/+/190761 https://bugs.eclipse.org/bugs/show_bug.cgi?id=477409 https://git.eclipse.org/r/c/platform/eclipse.platform.resources/+/190762 https://git.eclipse.org/c/platform/eclipse.platform.resources.git/commit/?id=223a2e5d6ff416d8bd4db7f0d961f664c5a1b613 https://git.eclipse.org/c/platform/eclipse.platform.resources.git/commit/?id=cecd165b5ac80ad89bf634a969cff16fb65a9dd4 |
||
Whiteboard: | |||
Bug Depends on: | |||
Bug Blocks: | 578640 |
Description
Andrey Loskutov
2022-02-14 00:47:09 EST
Jörg, could you please investigate? I suspect changes in job cancelation via bug 578578 could be related. Here, another log file, with probably the reason why following jobs see not modifiable tree state (notification manager must successfully complete, see Workspace startup code). https://ci.eclipse.org/jdt/job/eclipse.jdt.core-Gerrit/5905/artifact/org.eclipse.jdt.core.tests.compiler/target/work/data/.metadata/.log !ENTRY org.eclipse.core.jobs 4 2 2022-02-14 05:32:03.276 !MESSAGE An internal error occurred during: "Building". !STACK 0 java.lang.IllegalArgumentException: endRule without matching beginRule: R/ at org.eclipse.core.runtime.Assert.isLegal(Assert.java:66) at org.eclipse.core.internal.jobs.ImplicitJobs.end(ImplicitJobs.java:117) at org.eclipse.core.internal.jobs.JobManager.endRule(JobManager.java:726) at org.eclipse.core.internal.resources.WorkManager.checkOut(WorkManager.java:170) at org.eclipse.core.internal.resources.Workspace.endOperation(Workspace.java:1515) at org.eclipse.core.internal.events.AutoBuildJob.doBuild(AutoBuildJob.java:175) at org.eclipse.core.internal.events.AutoBuildJob.run(AutoBuildJob.java:254) at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63) !ENTRY org.eclipse.core.jobs 4 2 2022-02-14 05:32:04.773 !MESSAGE An internal error occurred during: "Updating workspace". !STACK 0 org.eclipse.core.runtime.AssertionFailedException: assertion failed: Mismatched begin/endOperation at org.eclipse.core.runtime.Assert.isTrue(Assert.java:113) at org.eclipse.core.internal.resources.Workspace.endOperation(Workspace.java:1492) at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2327) at org.eclipse.core.internal.events.NotificationManager$NotifyJob.run(NotificationManager.java:44) at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63) Likely bug 578640 patch https://git.eclipse.org/r/c/platform/eclipse.platform.resources/+/190567 is it. Could be also bug 578639 https://git.eclipse.org/r/c/platform/eclipse.platform.resources/+/190566 . Patch for bug 578578 is most likely unrelated. (In reply to Andrey Loskutov from comment #1) > Jörg, could you please investigate? i'll take a look. thanks for pointing o that. i can reproduce it when putting a breakpoint at AutoBuildJob.doBuild(IProgressMonitor):150 and then debug org.eclipse.jdt.core.tests.builder.BasicBuildTests as junit plugin test. once the breakpoint hit, wait a bit and resume => error. New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.resources/+/190761 (In reply to Jörg Kubitz from comment #5) > i can reproduce it when putting a breakpoint at > AutoBuildJob.doBuild(IProgressMonitor):150 and then debug > org.eclipse.jdt.core.tests.builder.BasicBuildTests as junit plugin test. > once the breakpoint hit, wait a bit and resume => error. So workspace.prepareOperation() was is never executed because job was interrupted in parallel, we do cancellation on interrupt now and subMonitor.split(1) was throwing OperationCanceledException because we've interrupted & cancelled the job. So https://git.eclipse.org/r/c/platform/eclipse.platform.resources/+/190567 was it. I assume subMonitor.split(1) should be called outside of try block. (In reply to Andrey Loskutov from comment #7) > I assume subMonitor.split(1) should be called outside of try block. There were lot of places where the problem may appear in that way after bug 477409 changes in resources framework, which is the actual root cause. They all may cause similar issues / should be fixed. New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.resources/+/190762 Funny enough, the PDE javadoc check job failed also with same issue yesterday: https://download.eclipse.org/eclipse/downloads/drops4/I20220213-1800/compilelogs/pde.doc.user.schema.txt [pde.convertSchemaToHTML] !SESSION 2022-02-13 23:45:07.976 ----------------------------------------------- [pde.convertSchemaToHTML] eclipse.buildId=unknown [pde.convertSchemaToHTML] java.version=11.0.2 [pde.convertSchemaToHTML] java.vendor=Oracle Corporation [pde.convertSchemaToHTML] BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US [pde.convertSchemaToHTML] Framework arguments: -application org.eclipse.ant.core.antRunner -quiet -buildfile buildDoc.xml -Dbasedir.properties=cbi_basedirs.properties -Declipse.javadoc=/opt/tools/java/openjdk/jdk-11/latest/bin/javadoc [pde.convertSchemaToHTML] Command-line arguments: -data /home/jenkins/agent/workspace/I-build-4.23-github/eclipse.platform.releng.aggregator/eclipse.platform.releng.aggregator/cje-production/gitCache/eclipse.platform.releng.aggregator/eclipse.platform.common/bundles/org.eclipse.pde.doc.user/target/eclipserun-work/data -consolelog -debug -data target/workspace -application org.eclipse.ant.core.antRunner -quiet -buildfile buildDoc.xml -Dbasedir.properties=cbi_basedirs.properties -Declipse.javadoc=/opt/tools/java/openjdk/jdk-11/latest/bin/javadoc [pde.convertSchemaToHTML] [pde.convertSchemaToHTML] !ENTRY org.eclipse.core.jobs 4 2 2022-02-13 23:45:10.149 [pde.convertSchemaToHTML] !MESSAGE An internal error occurred during: "Building". [pde.convertSchemaToHTML] !STACK 0 [pde.convertSchemaToHTML] java.lang.IllegalArgumentException: endRule without matching beginRule: R/ [pde.convertSchemaToHTML] at org.eclipse.core.runtime.Assert.isLegal(Assert.java:66) [pde.convertSchemaToHTML] at org.eclipse.core.internal.jobs.ImplicitJobs.end(ImplicitJobs.java:117) [pde.convertSchemaToHTML] at org.eclipse.core.internal.jobs.JobManager.endRule(JobManager.java:726) [pde.convertSchemaToHTML] at org.eclipse.core.internal.resources.WorkManager.checkOut(WorkManager.java:170) [pde.convertSchemaToHTML] at org.eclipse.core.internal.resources.Workspace.endOperation(Workspace.java:1515) [pde.convertSchemaToHTML] at org.eclipse.core.internal.events.AutoBuildJob.doBuild(AutoBuildJob.java:175) [pde.convertSchemaToHTML] at org.eclipse.core.internal.events.AutoBuildJob.run(AutoBuildJob.java:254) [pde.convertSchemaToHTML] at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63) Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.resources/+/190761 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.resources.git/commit/?id=223a2e5d6ff416d8bd4db7f0d961f664c5a1b613 Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.resources/+/190762 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.resources.git/commit/?id=cecd165b5ac80ad89bf634a969cff16fb65a9dd4 There were some thousands of resource related test fails in jdt.ui.tests and jdt.ui.tests.refactoring in https://download.eclipse.org/eclipse/downloads/drops4/I20220213-1800/testResults.php. I assume same root cause, but could be other issue too. Will see in the next build if they reappear or not. *** Bug 578730 has been marked as a duplicate of this bug. *** Let assume it is fixed now. |