Bug 575808

Summary:	E4 Parts without View Tag can show up in "Show View Dialog" as Category Children
Product:	[Eclipse Project] Platform	Reporter:	Mathias Mehrmann <mathias.mehrmann>
Component:	UI	Assignee:	Platform-UI-Inbox <Platform-UI-Inbox>
Status:	NEW ---	QA Contact:
Severity:	normal
Priority:	P3	CC:	Lars.Vogel
Version:	4.20
Target Milestone:	---
Hardware:	PC
OS:	Windows 10
Whiteboard:

Description Mathias Mehrmann

2021-09-03 06:12:46 EDT

While running into Bug#575329 we also found some discrepancies in our E4 Part definitions.

We had E4 parts that did not have a "View" Tag. 
But they had set a Category.

Normally org.eclipse.ui.internal.dialogs.ShowViewDialog will filter out MParts that are not a View (!isView(descriptor)).

But if you have a MPart which is a View and has the same category as a MPart that does not have it, this Non-View-MPart will also show up in that Category.

It's a wrong definition on our side that we already solved but also a possible inconcistency that costs us some time to find the problem.

org.eclipse.ui.internal.dialogs.ViewContentProvider.determineTopLevelElements(Object)
is using !isView(descriptor)

org.eclipse.ui.internal.dialogs.ViewContentProvider.determineViewsInCategory(String)
is not using it.

Wouldn't it be better if both locations react in the same way?

Comment 1 Lars Vogel

2021-09-03 06:16:40 EDT

(In reply to Mathias Mehrmann from comment #0)
> While running into Bug#575329 we also found some discrepancies in our E4
> Part definitions.
> 
> We had E4 parts that did not have a "View" Tag. 
> But they had set a Category.
> 
> Normally org.eclipse.ui.internal.dialogs.ShowViewDialog will filter out
> MParts that are not a View (!isView(descriptor)).
> 
> But if you have a MPart which is a View and has the same category as a MPart
> that does not have it, this Non-View-MPart will also show up in that
> Category.
> 
> It's a wrong definition on our side that we already solved but also a
> possible inconcistency that costs us some time to find the problem.
> 
> org.eclipse.ui.internal.dialogs.ViewContentProvider.
> determineTopLevelElements(Object)
> is using !isView(descriptor)
> 
> org.eclipse.ui.internal.dialogs.ViewContentProvider.
> determineViewsInCategory(String)
> is not using it.
> 
> Wouldn't it be better if both locations react in the same way?

Sounds reasonable. Please provide a Gerrit.