Bug 570406

Summary:	Declare Windows 10 compatibility in the manifest
Product:	[Eclipse Project] Equinox	Reporter:	Nikita Nemkin <nikita>
Component:	Launcher	Assignee:	Project Inbox <equinox.launcher-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	p.beauvoir, sravankumarl
Version:	4.19
Target Milestone:	4.22 M1
Hardware:	PC
OS:	Windows All
See Also:	https://git.eclipse.org/r/c/equinox/rt.equinox.framework/+/174915 https://bugs.eclipse.org/bugs/show_bug.cgi?id=560195 https://git.eclipse.org/c/equinox/rt.equinox.framework.git/commit/?id=6dd2c3f7fe4654b85ada31ca98b0509a3a41a8ea
Whiteboard:

Description Nikita Nemkin

2021-01-16 01:53:01 EST

Explicit compatibility declaration changes the behavior of some Win32 functions. java/javaw executables already do this (since at least Java 8) and we should minimize the difference.

Comment 1 Eclipse Genie

2021-01-16 01:56:24 EST

New Gerrit change created: https://git.eclipse.org/r/c/equinox/rt.equinox.framework/+/174915

Comment 2 Sravan Kumar Lakkimsetti

2021-01-19 02:27:10 EST

Can you please provide a link to the documentation of classid? I would like to review the information.

Comment 3 Sravan Kumar Lakkimsetti

2021-01-19 02:32:13 EST

found the documentation https://docs.microsoft.com/en-us/windows/win32/sysinfo/targeting-your-application-at-windows-8-1?redirectedfrom=MSDN

The change looks good. Should this one and Bug 560195 merged together?

Comment 4 Nikita Nemkin

2021-01-19 02:48:20 EST

(In reply to Sravan Kumar Lakkimsetti from comment #3)
> found the documentation
> https://docs.microsoft.com/en-us/windows/win32/sysinfo/targeting-your-
> application-at-windows-8-1?redirectedfrom=MSDN
> 
> The change looks good. Should this one and Bug 560195 merged together?

Yes, this patch makes sure there are no regressions in Eclipse after Bug 560195.
If you think Bug 560195 is fine, feel free to merge both.

Comment 5 Eclipse Genie

2021-09-22 06:57:12 EDT

Gerrit change https://git.eclipse.org/r/c/equinox/rt.equinox.framework/+/174915 was merged to [master].
Commit: http://git.eclipse.org/c/equinox/rt.equinox.framework.git/commit/?id=6dd2c3f7fe4654b85ada31ca98b0509a3a41a8ea

Comment 6 Sravan Kumar Lakkimsetti

2021-09-22 08:20:08 EDT

the launcher has been rebuilt with https://git.eclipse.org/c/equinox/rt.equinox.binaries.git/commit/?id=39eb2d942b9161793e2432239f4ddac932171484

Comment 7 Niraj Modi

2022-01-18 09:02:08 EST

*** Bug 551611 has been marked as a duplicate of this bug. ***