Bug 563329

Summary: [Dark theme] Ability to style the window title bar
Product: [Eclipse Project] Platform Reporter: Lars Vogel <Lars.Vogel>
Component: SWTAssignee: Alexandr Miloslavskiy <alexandr.miloslavskiy>
Status: RESOLVED FIXED QA Contact: Niraj Modi <niraj.modi>
Severity: enhancement    
Priority: P3 CC: 1520080049, alexandr.miloslavskiy, aobuchow, Lars.Vogel, niraj.modi, paul-eclipse, ts-swt, Vikas.Chandra
Version: 4.16Keywords: noteworthy
Target Milestone: 4.22 M2   
Hardware: PC   
OS: Windows 10   
See Also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=576614
https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/186458
https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=fb22c8ec55bee7b6eb77c862764a4e249176bc8a
https://git.eclipse.org/r/c/www.eclipse.org/eclipse/news/+/186647
https://git.eclipse.org/r/c/www.eclipse.org/eclipse/news/+/186648
https://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=a844a17aa70d8c8eb56caf3b2b11c218cc70f8cc
https://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=95f374623f2ac710a6a567b408ca89981f6985c7
https://git.eclipse.org/r/c/www.eclipse.org/eclipse/news/+/187732
https://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=5d3d5795fb29c679aaa73d7444f282b5a3264e8b
Whiteboard:
Bug Depends on:    
Bug Blocks: 576614    
Attachments:
Description Flags
Screenshot none

Description Lars Vogel CLA 2020-05-19 06:02:29 EDT 
Created attachment 282924 [details]
Screenshot

Similar to Bug 459789 for the Mac, we should allow to put the windows title bar into dark mode on Windows.
Comment 1 Andrew Obuchowicz CLA 2020-05-29 08:44:33 EDT 
See Paul's relevant comment https://bugs.eclipse.org/bugs/show_bug.cgi?id=563714#c5
Comment 2 Lars Vogel CLA 2020-06-12 08:21:08 EDT 
*** Bug 563714 has been marked as a duplicate of this bug. ***
Comment 3 Alexandr Miloslavskiy CLA 2021-09-29 08:55:58 EDT 
*** Bug 576321 has been marked as a duplicate of this bug. ***
Comment 4 Eclipse Genie CLA 2021-10-13 18:12:55 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/186458
Comment 5 Alexandr Miloslavskiy CLA 2021-10-13 18:14:49 EDT 
Good news: the necessary API is now documented; this also allows me to use it for older versions of Win10.

Here's the patch.
Comment 7 Niraj Modi CLA 2021-10-18 06:23:00 EDT 
(In reply to Eclipse Genie from comment #6)
> Gerrit change
> https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/186458 was
> merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=fb22c8ec55bee7b6eb77c862764a4e249176bc8a

Thanks Alexandr for this dark-theme improvement.
We also need N&N entry for 4.22
Comment 8 Lars Vogel CLA 2021-10-18 06:36:20 EDT 
Thanks Alexandr for this feature and Niraj for the review.

Alexandr/ Niraj, do I need to do something in our org.eclipse.e4.ui.swt.internal.win32.DarkThemeProcessor? Currently we only call 			OS.setTheme (isDark);
Comment 9 Alexandr Miloslavskiy CLA 2021-10-18 07:29:53 EDT 
No need to do anything, the patch amends 'OS.setTheme()', see [1] line 2249

Lars, would you make a N&N entry?

[1] https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/186458/6/bundles/org.eclipse.swt/Eclipse+SWT+PI/win32/org/eclipse/swt/internal/win32/OS.java
Comment 10 Lars Vogel CLA 2021-10-18 09:06:48 EDT 
(In reply to Alexandr Miloslavskiy from comment #9)
> No need to do anything, the patch amends 'OS.setTheme()', see [1] line 2249
> 
> Lars, would you make a N&N entry?

Yes, will do with tomorrows I-Build.
Comment 11 Eclipse Genie CLA 2021-10-19 04:29:44 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/www.eclipse.org/eclipse/news/+/186647
Comment 12 Eclipse Genie CLA 2021-10-19 04:33:56 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/www.eclipse.org/eclipse/news/+/186648
Comment 15 Niraj Modi CLA 2021-10-22 03:22:15 EDT 
(In reply to Lars Vogel from comment #10)
> (In reply to Alexandr Miloslavskiy from comment #9)
> > No need to do anything, the patch amends 'OS.setTheme()', see [1] line 2249
> > 
> > Lars, would you make a N&N entry?
> 
> Yes, will do with tomorrows I-Build.

Thanks Lars for the N&N entry, resolving now.
Comment 16 Vikas Chandra CLA 2021-11-11 05:59:08 EST 
The image in the N&N is greater than 800px whereas the instruction caps the width to 800px.

Can you upload with an image <=800px in width?
Comment 17 Lars Vogel CLA 2021-11-15 05:21:02 EST 
(In reply to Vikas Chandra from comment #16)
> The image in the N&N is greater than 800px whereas the instruction caps the
> width to 800px.
> 
> Can you upload with an image <=800px in width?

Done.
Comment 18 Eclipse Genie CLA 2021-11-15 05:21:37 EST 
New Gerrit change created: https://git.eclipse.org/r/c/www.eclipse.org/eclipse/news/+/187732