Bugzilla – Full Text Bug Listing
Created attachment 275725 [details]
Native Tabs on Linux
Created attachment 275726 [details]
Native Tabs on Linux - LIght theme
New Gerrit change created: https://git.eclipse.org/r/128851 Matthias, what do you think of the change? Can you upload screenshots about the difference under Mac? To give my opinion, I don't link the native tabs a lot. An alternative experiment would be to adjust the CTabRendering implementation to draw flat tabs. Created attachment 275727 [details]
Current dark styling
Created attachment 275728 [details]
Current light styling under Linux
Created attachment 275740 [details]
Current rendering
Created attachment 275741 [details]
rendering with lars change
Created attachment 275742 [details]
google chrome currently on macOS
I would not say that "modern" applications avoid curved corners.
Just look how the current version of chrome does draw tabs
FYI - Several people on the EclipseCon complained about the default tabs in Eclipse. We should try to provide them without drawing artifacts (the corners are currently pixelated). Created attachment 279032 [details]
Screenshot
Screenshot compares Code tab style with Eclipse. Code looks way better IMHO.
Mike indicated via email that he is interest to contribute this. Mike, as discussed would be great to have this in CTabFolderRenderer and allow to set via CSS property. New Gerrit change created: https://git.eclipse.org/r/160948 Created attachment 282443 [details]
Square Tabs
New Gerrit change created: https://git.eclipse.org/r/160949 (In reply to Eclipse Genie from comment #16) > New Gerrit change created: https://git.eclipse.org/r/160949 shouldn't his be an amend to https://git.eclipse.org/r/160948? Created attachment 282447 [details]
Jagged corners
What is the general feeling about moving to square tabs? The "rounded" corners are not really round, especially on low resolutions they look bad, see screenshot. Other successful newcomers use square corners. IMHO our round corners look outdated. (In reply to Lars Vogel from comment #19) > What is the general feeling about moving to square tabs? As long as it doesn't affect usability (ie color palette, close icon, styled label, context menu), I personally don't care. I think the CTab should try to inherit as much as possible from the OS native tabs. So if all supported OS native tabs are all square in the OS, then let's just mimic it be default. I have updated the patch for this enhancement. I have removed the concept of a property for corner shape and we are just using corner radius 0 to indicate to CTabRendering that the tabs should be square. Marking this as depending on Bug 562183 since it will not look correct until the trim computation is no longer using cornerSize. Have you tried using the CTabFolder.setSimple(true) to get the simple, not-rounded tabs? This can already be enabled in Eclipse to see how it looks by disabling theming - General > Appearance > uncheck 'Enable theming'. (In reply to Lakshmi Shanmugam from comment #22) > Have you tried using the CTabFolder.setSimple(true) to get the simple, > not-rounded tabs? > This can already be enabled in Eclipse to see how it looks by disabling > theming - General > Appearance > uncheck 'Enable theming'. The issue with disabled theme IMO is that we miss the various tab colors that help to easily identify which tabFoder/tab is active and has focus. (In reply to Mickael Istria from comment #23) > (In reply to Lakshmi Shanmugam from comment #22) > > Have you tried using the CTabFolder.setSimple(true) to get the simple, > > not-rounded tabs? > > This can already be enabled in Eclipse to see how it looks by disabling > > theming - General > Appearance > uncheck 'Enable theming'. > > The issue with disabled theme IMO is that we miss the various tab colors > that help to easily identify which tabFoder/tab is active and has focus. We won't be able to select dark theme or other themes too if theming is disabled. I was suggesting to disable the theming only to see how the simple tabs look in Eclipse. If the tabs looks good, CTabFolder.setSimple() can be enabled to get the look, may be even via CSS. Created attachment 282467 [details]
Linux no theming
Screenshot of Linux with theming turned of, so square tabs looks more natural.
Lars, I should point out that those simple tabs aren't square. (In reply to Mike Marchand from comment #26) > Lars, I should point out that those simple tabs aren't square. Less round :-) Gerrit change https://git.eclipse.org/r/160948 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=9c74e2cf1d925d37fb7f8a4c1bd387e27cab4448 New Gerrit change created: https://git.eclipse.org/r/161076 I adjusted this bug to provide the implementation of square tabs. How we use them will be handled via Bug 562221. I can image that we have users which loves our round tabs and that we have users which would love square tabs. Thanks, Mike for this nice new option. Could you provide an N&N for this new option? See https://git.eclipse.org/r/#/c/160926/ for an example. New Gerrit change created: https://git.eclipse.org/r/161111 Added a new and noteworthy snippet with some screenshots of light and dark themes. *** Bug 491032 has been marked as a duplicate of this bug. *** Lars, I don't think that was the correct bug to mark as a duplicate to this one. Gerrit change https://git.eclipse.org/r/161111 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=6eac6c3f58ecb9950dbfa91d0f6ff5e2e6329c58 This bug fix caused regression in Eclipse bug 563423. (In reply to Niraj Modi from comment #37) > This bug fix caused regression in Eclipse bug 563423. And another regression in bug 563575. Please check if that could be fixed for RC1. Note also bug 563585. |
Created attachment 275723 [details] Screenshot IIRC Eclipse 4.2 was released around 2012 and introduced "rounded tabs" styling for CTabFolder. In a recent developer discussion, the topic came up. It was stated that the rounded tabs of Eclipse look "old", "outdated" or "ridiculous", as it was phrased. Looking at the most used application on my desktop the Browser and at several popular Android apps, I must agree, the current styling in Eclipse does not look modern. Modern application seem to avoid rounded tabs. See attachment for Chrome and Firefox. I suggest we switch back to use default tabs from the OS. This way the tabs of Eclipse will be in sync with the OS.