Bugzilla – Full Text Bug Listing
| Summary: | [9] Help contexts for new dialogs relating to modularity details | ||
|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Dani Megert <daniel_megert> |
| Component: | UI | Assignee: | Stephan Herrmann <stephan.herrmann> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | daniel_megert, manoj.palat, niraj.modi, noopur_gupta, sarika.sinha, stephan.herrmann |
| Version: | 4.8 | Keywords: | Documentation |
| Target Milestone: | 4.9 RC1 | Flags: | sarika.sinha:
review+
|
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://git.eclipse.org/r/128116 https://git.eclipse.org/r/128117 https://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=4534e050ac2053e156d7d4d65f52d41e46314d58 https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=34920635774c895c5db6656e9c9936592c33e12e |
||
| Whiteboard: | |||
| Bug Depends on: | 519444, 521663 | ||
| Bug Blocks: | |||
|
Description
Dani Megert
New Gerrit change created: https://git.eclipse.org/r/128116 New Gerrit change created: https://git.eclipse.org/r/128117 Sarika, may I ask your +1 for inclusion in RC1? (In reply to Eclipse Genie from comment #1) > New Gerrit change created: https://git.eclipse.org/r/128116 This is the code change in JDT/UI. (In reply to Eclipse Genie from comment #2) > New Gerrit change created: https://git.eclipse.org/r/128117 This is stub content in the doc bundle. I hope it's OK to only have the trivial code change reviewed, as I'm planning to write the real content later today, when you may already have left the office ... One tiny issue in the HTML: I inserted a link to the JPMS JSR, but this doesn't work in the help window on my linux box. Only if I say "open in new window", it opens, in a near-zero-sized window, which after enlarging shows the correct content. Is that a bug in the help system - me doing s.t. wrong - or a quirk of that particular page? Any idea? Does it work on other platforms? +1 for JDT UI Changes. JDT Doc changes does not require +1 for RC1, you can release the changes. I tried out the jdt doc patch, I was able to click the link for <a href="http://openjdk.java.net/projects/jigsaw/spec"> and it opened properly on Windows. Gerrit change https://git.eclipse.org/r/128117 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=4534e050ac2053e156d7d4d65f52d41e46314d58 (In reply to Eclipse Genie from comment #5) > Gerrit change https://git.eclipse.org/r/128117 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/ > ?id=4534e050ac2053e156d7d4d65f52d41e46314d58 Completed doc content. Gerrit change https://git.eclipse.org/r/128116 was merged to [master]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=34920635774c895c5db6656e9c9936592c33e12e (In reply to Sarika Sinha from comment #4) > +1 for JDT UI Changes. Thanks, Sarika, After rebase I directly pushed: (In reply to Eclipse Genie from comment #7) > Gerrit change https://git.eclipse.org/r/128116 was merged to [master]. > Commit: > http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/ > ?id=34920635774c895c5db6656e9c9936592c33e12e gerrit queue is totally jammed, apparently a flood of EPL 2.0 changes, but we already had a successful build :) BTW: comments on the documentation are of course welcome, too. Looks Good Stephan!! Regarding --add-reads - In other words: the source module will be made to "read" the target module. Not sure, but "made to read" somehow struck me - In other words: the target module will be made available for "read" for the source module. Is that what you meant? Verified using Eclipse SDK Version: 2018-09 (4.9) Build id: I20180829-2000 |