Bug 530966

Summary: Add "Clear History" item to "Recent Files" menu
Product: [Eclipse Project] Platform Reporter: Patrik Suzzi <psuzzi>
Component: UIAssignee: Patrik Suzzi <psuzzi>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: loskutov
Version: 4.8   
Target Milestone: ---   
Hardware: All   
OS: All   
See Also: https://git.eclipse.org/r/117087
https://bugs.eclipse.org/bugs/show_bug.cgi?id=529885
https://git.eclipse.org/c/.git/commit/?id=dac960ed50b8732911fa4c252c1d836773fd782f
https://bugs.eclipse.org/bugs/show_bug.cgi?id=543269
Whiteboard:
Attachments:
Description Flags
Clear History in the Open Recent menu none

Description Patrik Suzzi CLA 2018-02-09 14:06:16 EST
Add a "Clear History" menu item to the "Recent Documents" menu added in bug 529885.
Comment 1 Patrik Suzzi CLA 2018-02-09 16:56:23 EST
Created attachment 272621 [details]
Clear History in the Open Recent menu
Comment 2 Patrik Suzzi CLA 2018-02-09 19:07:12 EST
New Gerrit change created: https://git.eclipse.org/r/#/c/117087/
Comment 3 Patrik Suzzi CLA 2018-02-10 05:04:25 EST
As reported in Gerrit's comment: 

Please hide or disable the menu item if the history is empty.


However, 

I think it is better to leave the menu and show only one menuitem, like "Clear History", to signal the history is empty. 
For example, in VS code, you still have the "Reopen Closed Editor" item, see https://i.imgur.com/DgzulSR.png
Or, in Atom you still have the Clear History item, see https://imgur.com/RMWe7E9.png.
Since this is part of the discussion, I'll put it on the bug.

Aby contribution to the discussion is welcome!
Comment 4 Andrey Loskutov CLA 2018-02-10 14:32:55 EST
I think we can leave "Clear history" if there is no history, but this entry must be disabled.
Comment 5 Eclipse Genie CLA 2018-02-11 10:15:35 EST
Gerrit change https://git.eclipse.org/r/117087 was merged to [master].
Commit: http://git.eclipse.org/c/.git/commit/?id=dac960ed50b8732911fa4c252c1d836773fd782f