Bug 516364

Summary:	Replace use of HOVER_ color with INFORMATION_
Product:	[Eclipse Project] JDT	Reporter:	Leo Ufimtsev <lufimtse>
Component:	UI	Assignee:	Roland Grunberg <rgrunber>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	daniel.kruegler, daniel_megert, gautier.desaintmartinlacaze, lufimtse, noopur_gupta, rgrunber
Version:	4.7
Target Milestone:	4.8 M7
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/#/c/96117/ https://git.eclipse.org/r/96117 https://bugs.eclipse.org/bugs/show_bug.cgi?id=516003 https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=90a8e6638fa8e2302d64362c29df955c302b73e4
Whiteboard:
Bug Depends on:	508819
Bug Blocks:	507072

Description Leo Ufimtsev

2017-05-09 09:24:27 EDT

Once API is defined:
https://git.eclipse.org/r/#/c/96122/

I should replace string instances of:
org.eclipse.ui.workbench.HOVER_FOREGROUND
org.eclipse.ui.workbench.HOVER_BACKGROUND

With:
org.eclipse.ui.workbench.INFORMATION_FOREGROUND
org.eclipse.ui.workbench.INFORMATION_BACKGROUND
But not the string, but instead reference the API that will be defined in  JFacePreferences.java:
INFORMATION_FOREGROUND_COLOR
INFORMATION_BACKGROUND_COLOR

Related patches that I can base things of:
https://git.eclipse.org/r/#/c/96117/
https://git.eclipse.org/r/#/c/96123/

Comment 1 Leo Ufimtsev

2017-10-12 11:50:28 EDT

Dependent merged. I'll need to look into this. Currently pending till I finish webkit2 port.

Comment 2 Leo Ufimtsev

2018-02-08 09:19:12 EST


As a note:

org.eclipse.jdt.ui.Javadoc.backgroundColor

Comment 3 Leo Ufimtsev

2018-02-08 09:25:33 EST

@Roland

1) I dug up a patch I wrote a long time ago to replace the HOVER_ with INFORMATION_ in jdt:
https://git.eclipse.org/r/#/c/96117

I just updated the patch a bit, but I think it needs a rebase and a bit of testing/Roland's touch.

2) Also, this file contains a reference to HOVER_, which should probably be updated to INFORMATION_
/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/themes/RGBInfoColorFactory.java

3) as well as possibly this guy:
/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/hover/AbstractAnnotationHover.java

4) In general, I think HOVER_* shouldn't be used anywhere to complete this task.
(Let me know, I can open all projects I've worked on and do a quick search to verify).

Comment 4 Noopur Gupta

2018-03-28 01:39:49 EDT

I'll have a look post Java 10 work.

Comment 5 Eclipse Genie

2018-04-16 07:27:22 EDT

Gerrit change https://git.eclipse.org/r/96117 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=90a8e6638fa8e2302d64362c29df955c302b73e4

Comment 6 Noopur Gupta

2018-04-16 07:30:27 EDT

Thanks, Leo and Roland for the patch.

Comment 7 Dani Megert

2018-04-25 11:52:39 EDT

Verfied in I20180422-2000.