Bug 500617

Summary: [problems view] Add buttons to Problem View, to open Filter
Product: [Eclipse Project] Platform Reporter: Lars Vogel <Lars.Vogel>
Component: UIAssignee: Ian Pun <ipun>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: akurtakov, atrookey, daniel_megert, ipun, Lars.Vogel, lufimtse, mistria, pwebster, sxenos
Version: 4.7Keywords: noteworthy
Target Milestone: 4.7 M2   
Hardware: All   
OS: All   
See Also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=498356
https://git.eclipse.org/r/80222
https://bugs.eclipse.org/bugs/show_bug.cgi?id=465914
https://git.eclipse.org/r/#/c/80500/
https://git.eclipse.org/r/80500
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=3edac4c8cc78f94b0f55a99fd6cee612f2121099
https://git.eclipse.org/r/80729
https://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=b53316b967001abbbe878a1f94ae5970315a3290
Whiteboard:
Bug Depends on:    
Bug Blocks: 511269, 500779    
Attachments:
Description Flags
Brief demonstration of the filter button on the toolbar none

Description Lars Vogel CLA 2016-08-31 18:12:24 EDT 
We should add a button to open the filter to the Problem view / Bookmark and Tasks view. See also Bug 498356
Comment 1 Eclipse Genie CLA 2016-09-01 09:48:58 EDT 
New Gerrit change created: https://git.eclipse.org/r/80222
Comment 2 Ian Pun CLA 2016-09-01 09:50:41 EDT 
Added changes from Bug 498356 over to this instead. Ready for review and comments about possible choice of Filter icon.
Comment 3 Lars Vogel CLA 2016-09-01 10:00:48 EDT 
(In reply to Ian Pun from comment #2)
> Added changes from Bug 498356 over to this instead. Ready for review and
> comments about possible choice of Filter icon.

At the moment I suggest to use the same filter icon as JDT in the package explorer. Mid-term we should really find a better filter icon for Eclipse. See Bug 465914.
Comment 4 Ian Pun CLA 2016-09-06 10:45:05 EDT 
(In reply to Lars Vogel from comment #3)
> (In reply to Ian Pun from comment #2)
> > Added changes from Bug 498356 over to this instead. Ready for review and
> > comments about possible choice of Filter icon.
> 
> At the moment I suggest to use the same filter icon as JDT in the package
> explorer. Mid-term we should really find a better filter icon for Eclipse.
> See Bug 465914.

Hi Lars,

I noticed that you've created additional bugs for the different views that you wish to have the button on. All those views are actually part of the extendedMarkersView. Perhaps I can find a way to override that view so that all of those views listed will have the filter?
Comment 5 Eclipse Genie CLA 2016-09-06 16:51:10 EDT 
New Gerrit change created: https://git.eclipse.org/r/80500
Comment 6 Mickael Istria CLA 2016-09-07 04:08:15 EDT 
@Ian: can you please provide a screenshot on this bug? It makes it easier to understand the proposal and we could reuse it for the N&N.
Comment 7 Ian Pun CLA 2016-09-07 10:55:12 EDT 
Created attachment 264009 [details]
Brief demonstration of the filter button on the toolbar
Comment 9 Lars Vogel CLA 2016-09-08 03:40:31 EDT 
Awesome Ian. Can you please add a new entry for this in our N&N for 4.7 M2?
Comment 10 Lars Vogel CLA 2016-09-08 08:27:22 EDT 
*** Bug 500779 has been marked as a duplicate of this bug. ***
Comment 11 Lars Vogel CLA 2016-09-08 08:27:46 EDT 
*** Bug 500778 has been marked as a duplicate of this bug. ***
Comment 12 Eclipse Genie CLA 2016-09-08 15:41:34 EDT 
New Gerrit change created: https://git.eclipse.org/r/80729
Comment 13 Ian Pun CLA 2016-09-08 15:47:31 EDT 
(In reply to Lars Vogel from comment #9)
> Awesome Ian. Can you please add a new entry for this in our N&N for 4.7 M2?

Hi Lars,

I updated the N&N; hopefully I did it correctly. Took me a bit of time to get it configured