Bug 495909

Summary:	[GTK3.20+] test_setTopItemLorg_eclipse_swt_widgets_TreeItem() fails
Product:	[Eclipse Project] Platform	Reporter:	Eric Williams <ericwill>
Component:	SWT	Assignee:	Ian Pun <ipun>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	chanskw, lufimtse, malaperle, tom.schindl
Version:	4.6	Keywords:	test
Target Milestone:	4.7 M1
Hardware:	PC
OS:	Linux
See Also:	https://git.eclipse.org/r/75178 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=7e5f98bb2b5f6f1dadb9ec6a9723c4817caab045 https://git.eclipse.org/r/75997 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=34555ac22b01bd1b982cb5d3784d41d1c9241dd7 https://git.eclipse.org/r/76014 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=c1aa36436e881ddc20f54147fbf3ead08989f297 https://git.eclipse.org/r/76144 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=a5877a53231f7c5c335c58415c50611fa5ff1b59 https://bugs.eclipse.org/bugs/show_bug.cgi?id=501420
Whiteboard:
Bug Depends on:
Bug Blocks:	461354, 496780

Description Eric Williams

2016-06-10 14:36:21 EDT

On GTK3.20 and above, test_setTopItemLorg_eclipse_swt_widgets_TreeItem() fails.

Comment 1 Eclipse Genie

2016-06-13 14:50:54 EDT

New Gerrit change created: https://git.eclipse.org/r/75178

Comment 2 Eclipse Genie

2016-06-23 14:15:11 EDT

Gerrit change https://git.eclipse.org/r/75178 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=7e5f98bb2b5f6f1dadb9ec6a9723c4817caab045

Comment 3 Eric Williams

2016-06-23 14:15:38 EDT

(In reply to Eclipse Genie from comment #2)
> Gerrit change https://git.eclipse.org/r/75178 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=7e5f98bb2b5f6f1dadb9ec6a9723c4817caab045

In master now, thanks for the patch Ian. AllNonBrowser JUnit tests back to passing on all versions of GTK.

Comment 4 Eclipse Genie

2016-06-27 07:02:25 EDT

New Gerrit change created: https://git.eclipse.org/r/75997

Comment 5 Eclipse Genie

2016-06-27 07:05:17 EDT

Gerrit change https://git.eclipse.org/r/75997 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=34555ac22b01bd1b982cb5d3784d41d1c9241dd7

Comment 6 Leo Ufimtsev

2016-06-27 10:23:08 EDT

This patch broke:
Bug 496780 - Bug201002TreeViewerTest.testBug201002 fails on Gerrit 

We should revert/investigate.

Comment 7 Eclipse Genie

2016-06-27 10:37:58 EDT

New Gerrit change created: https://git.eclipse.org/r/76014

Comment 8 Eclipse Genie

2016-06-27 10:46:36 EDT

Gerrit change https://git.eclipse.org/r/76014 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=c1aa36436e881ddc20f54147fbf3ead08989f297

Comment 9 Eric Williams

2016-06-27 10:47:39 EDT

(In reply to Eclipse Genie from comment #8)
> Gerrit change https://git.eclipse.org/r/76014 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=c1aa36436e881ddc20f54147fbf3ead08989f297

I've reverted the fix for now, Ian will investigate.

Comment 10 Eclipse Genie

2016-06-28 11:54:52 EDT

New Gerrit change created: https://git.eclipse.org/r/76144

Comment 11 Eclipse Genie

2016-07-06 15:16:02 EDT

Gerrit change https://git.eclipse.org/r/76144 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=a5877a53231f7c5c335c58415c50611fa5ff1b59

Comment 12 Eric Williams

2016-07-06 15:16:49 EDT

(In reply to Eclipse Genie from comment #11)
> Gerrit change https://git.eclipse.org/r/76144 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=a5877a53231f7c5c335c58415c50611fa5ff1b59

In master now. Adds a regression test and fixes the failing Platform UI test case. Thanks for the patch Ian!

Comment 13 Leo Ufimtsev

2016-07-07 09:56:30 EDT

It's always nice to see junits being fixed. Thanks for the patch.

Comment 14 Eric Williams

2016-10-18 12:05:18 EDT

*** Bug 74739 has been marked as a duplicate of this bug. ***

Comment 15 Eric Williams

2016-10-18 12:06:02 EDT

*** Bug 202392 has been marked as a duplicate of this bug. ***

Comment 16 Marc-André Laperle

2016-11-02 22:18:31 EDT

*** Bug 490240 has been marked as a duplicate of this bug. ***