Bug 474677

Summary:	Line style menus and buttons in appearance property section are always disabled
Product:	[Modeling] Sirius	Reporter:	Maxime Porhel <maxime.porhel>
Component:	Diagram	Assignee:	Project Inbox <sirius.diagram-inbox>
Status:	NEW ---	QA Contact:
Severity:	normal
Priority:	P3	CC:	florian.barbin
Version:	3.0.0	Keywords:	triaged
Target Milestone:	---
Hardware:	PC
OS:	Mac OS X
Whiteboard:
Bug Depends on:	461590
Bug Blocks:

Description Maxime Porhel

2015-08-11 04:23:26 EDT

Discovered during Bug 461590 which add the line type capability to node and container borders. 

Step to reproduce: 
 . open a diagram (seeBug 461580 which provide a use case with all tests)
 . select iteratively each node/container/edge
 . in the apperance property tab, the button from "Lines and Arrows" group are always disabled


Some entry point for the analyse
 . ViewPropertiesSynchronizer
 . *ViewFactory
 . there is no LineStypeStyle on our GMF views: org.eclipse.gmf.runtime.diagram.ui.properties.sections.appearance.ColoursAndFontsAndLineStylesPropertySection.refresh() will never enable the buttons

We could at least enable the line type button, maybe the line width combo but not the arrow one for nodes/container; 

The other solution is to hide this group as some of these elements can be customized from the "Style" tab.

Comment 1 Maxime Porhel

2015-08-20 11:13:54 EDT

This comes mainly from the fact that there is no notation LineStyle on our edges and nodes views. 

We have to solutions here: 
 . Add the line style (and the arrow, width and other styles corresponding to non working menus)
 . Remove the default menu and buttons and replace them by Sirius specific ones able to handle our style elements (bonus: no need to maintain/synchronize/revert the notation changes)

Comment 2 Maxime Porhel

2015-08-20 11:15:29 EDT

Additional step in the reproduction case: right click > Format > Line style > grayed menus.