Bug 454476

Summary:

[rulers] "Show Revision Information" should be a toggle

Product:

[Eclipse Project] Platform

Reporter:

Ed Willink <ed>

Component:

Text

Assignee:

Platform-Text-Inbox <platform-text-inbox>

Status:

ASSIGNED ---

QA Contact:

Severity:

enhancement

Priority:

CC:

albert.tregnaghi, daniel_megert, eclipse, gautier.desaintmartinlacaze, loskutov, matthias.sohn, reckord, twolf

Version:

3.8.2

Keywords:

helpwanted

Target Milestone:

---

Hardware:

All

OS:

All

See Also:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=505939
https://bugs.eclipse.org/bugs/show_bug.cgi?id=274691

Whiteboard:

Attachments:

Description	Flags
Sceen shot	none

Description Ed Willink

2014-12-08 13:01:04 EST

Editing with Show Annotations on gives m,any UI freeezes, particular if the debugger is using the same source file as the current line.

Therefore it is important to allow Blame Annotations to be switched off once no longer needed.

This would be easy if Show Annotations in the menu was a toggle in the same way as Show QuickDiff.

Workaround: Close the editor then back to reopen it.

Comment 1 Matthias Sohn

2014-12-09 06:34:09 EST

You can close the annotations from the context menu of the annotations side bar, 
click "Revisions > Hide Revision Information"

Comment 2 Matthias Sohn

2014-12-09 06:35:11 EST

Are you really using Windows NT ?

Comment 3 Ed Willink

2014-12-09 07:01:36 EST

(In reply to Matthias Sohn from comment #2)
> Are you really using Windows NT ?

No Windows 8.1.

(In reply to Matthias Sohn from comment #1)
> You can close the annotations from the context menu of the annotations side
> bar, 
> click "Revisions > Hide Revision Information"

Thanks. Useful, but not obvious. Still worth having the switch it off the same way you switched it on menu paths.

Comment 4 Thomas Wolf

2016-10-14 18:48:39 EDT

(In reply to Ed Willink from comment #3)
> (In reply to Matthias Sohn from comment #1)
> > You can close the annotations from the context menu of the annotations side
> > bar, 
> > click "Revisions > Hide Revision Information"
> 
> Thanks. Useful, but not obvious. Still worth having the switch it off the
> same way you switched it on menu paths.

I agree, but unfortunately that whole "Revisions" submenu is hard-coded in AbstractDecoratedTextEditor. I don't see an obvious way how we could suppress that nested "Revisions > Hide Revision Information" menu entry and turn "Show Revision Information" into a toggle instead.

Comment 5 Thomas Wolf

2016-12-23 16:16:58 EST

*** Bug 509690 has been marked as a duplicate of this bug. ***

Comment 6 Leo Ufimtsev

2017-01-03 11:23:46 EST

Updating bug title as option was renamed.

Comment 7 Leo Ufimtsev

2017-01-03 11:24:27 EST

Created attachment 266103 [details]
Sceen shot

Comment 8 Andrey Loskutov

2017-01-12 10:20:58 EST

*** Bug 510371 has been marked as a duplicate of this bug. ***

Comment 9 Dani Megert

2017-03-22 12:17:09 EDT

> "Show Revision Information" should be a Toggle
	
I agree.

Comment 10 Andrey Loskutov

2017-05-24 05:38:07 EDT

*** Bug 517167 has been marked as a duplicate of this bug. ***

Comment 11 Dani Megert

2018-05-24 12:52:18 EDT

Removing target milestone for all bugs that are not major or above.

Comment 12 Dani Megert

2018-05-25 04:07:32 EDT

> Removing target milestone for all bugs that are not major or above.

Of course I meant "major or below".

Sorry for the noise!