Bug 400129

Summary:

[ua] NPE when registering context help for non-plugin project

Product:

[Eclipse Project] PDE

Reporter:

Szymon Ptaszkiewicz <sptaszkiewicz>

Component:

Assignee:

Curtis Windatt <curtis.windatt.public>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

curtis.windatt.public, ivyho

Version:

4.3

Keywords:

contributed

Target Milestone:

4.3 M6

Flags:

curtis.windatt.public: review+

Hardware:

All

OS:

All

Whiteboard:

Bug Depends on:

Bug Blocks:

401435

Attachments:

Description	Flags
Log with NPE	none
Fix analogous to the fix for bug 273049	curtis.windatt.public: iplog+

Description Szymon Ptaszkiewicz

2013-02-06 12:30:08 EST

Created attachment 226651 [details]
Log with NPE

It is wrong to register context help for a non-plugin project, but the error message could be more descriptive than NPE.

Steps to reproduce:
1. Create new General Project.
2. Create new Context Help in that project.
3. Click "Register this context help file" in the top right corner of Context Help Editor.
4. Click Finish.
=> Error dialog with NPE appears.

Similar to bug 273049 comment 3.

Comment 1 Szymon Ptaszkiewicz

2013-02-06 13:17:16 EST

Created attachment 226653 [details]
Fix analogous to the fix for bug 273049

Comment 2 Szymon Ptaszkiewicz

2013-02-06 13:19:06 EST

Curtis, please review when you get a moment. Thanks!

Comment 3 Curtis Windatt

2013-02-06 13:53:49 EST

Fixed in master
http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=04501d661416491d08387b4825bf9ff11bfb832e

I also fixed the duplicate NPE in the table of contents editor.  The formatter made a number of extra changes to the file.  I updated the x-friends so this change didn't add a warning.

Comment 4 Ivy Ho

2013-02-20 09:49:04 EST

Hi  Syzmon: can you please help to open an IES bugzilla? The RAD team said that they will need this IES bugzilla number so that they can pick up the fix.
Thanks so much.