Bug 374116

Summary: RCP apps initial window shows title "%trimmedwindow.label.eclipseSDK"
Product: [Eclipse Project] Platform Reporter: Brian de Alwis <bsd>
Component: UIAssignee: Brian de Alwis <bsd>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P1 CC: dastoaster, Lars.Vogel, pwebster, simon.scholz
Version: 4.2   
Target Milestone: 4.2 M6   
Hardware: All   
OS: All   
See Also: https://git.eclipse.org/r/43074
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=81e1214db9b70523c4166e4f9072db20c2ba34ca
Whiteboard:
Attachments:
Description Flags
Strip out the %trimmedwindow.label.eclipseSDK none

Description Brian de Alwis CLA 2012-03-13 13:35:16 EDT
Created attachment 212579 [details]
Strip out the %trimmedwindow.label.eclipseSDK

Version: 4.2.0
Build id: I20120313-0610

The initial window for RCP apps shows a title of "%trimmedwindow.label.eclipseSDK".  The cause is a mismatch between the translated string key in the code and the plugin.properties file, which uses "trimmedwindow.label.1", done in bug 351033.

But as I pointed out in bug 372523, RCP apps don't want a string showing "Eclipse SDK 4.0" on startup anyways.

Attached patch strips out the window label and the now-useless key from the translation file.
Comment 2 Lars Vogel CLA 2012-03-14 04:47:17 EDT
*** Bug 373988 has been marked as a duplicate of this bug. ***
Comment 3 Torsten Witte CLA 2015-01-30 07:37:32 EST
The LegacyIDE.e4xmi files in the org.eclipse.ui.workbench bundles of eclipse 4.3 and 4.4 contain the entry 'label="%trimmedwindow.label.eclipseSDK"' again, so the window title of my rcp app contains the text "%trimmedwindow.label.eclipseSDK".

Any ideas?
Comment 4 Eclipse Genie CLA 2015-03-03 07:58:33 EST
New Gerrit change created: https://git.eclipse.org/r/43074
Comment 5 Simon Scholz CLA 2015-03-03 07:59:06 EST
Thanks for pointing at this, Torsten. I just had a look at the git history and figured out that Paul has added the label again within this commit: 
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=8f2a2860a007b7321d03dcae23bb10941a12ffea

Maybe by accident.
So I add Paul here, but also directly provide a patch for this. (https://git.eclipse.org/r/43074)
Comment 6 Paul Webster CLA 2015-03-03 08:47:22 EST
Sorry if I added that back.  I'll push the change on Monday if no one gets to it first.

That probably got in because there are 2 of those files (the one in o.e.ui.workbench is a backup).  Can you check both?  The other should be in platform/eclipse.platform.git

PW
Comment 7 Paul Webster CLA 2015-03-03 08:48:29 EST
(In reply to Paul Webster from comment #6)
> That probably got in because there are 2 of those files (the one in
> o.e.ui.workbench is a backup).  Can you check both? 

Actually, the second one in eclipse.platform is supposed to have the label, so that's OK

PW
Comment 9 Lars Vogel CLA 2015-03-08 03:42:32 EDT
Thanks Simon.