Summary: | RCP apps initial window shows title "%trimmedwindow.label.eclipseSDK" | ||||||
---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Brian de Alwis <bsd> | ||||
Component: | UI | Assignee: | Brian de Alwis <bsd> | ||||
Status: | RESOLVED FIXED | QA Contact: | |||||
Severity: | normal | ||||||
Priority: | P1 | CC: | dastoaster, Lars.Vogel, pwebster, simon.scholz | ||||
Version: | 4.2 | ||||||
Target Milestone: | 4.2 M6 | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
See Also: |
https://git.eclipse.org/r/43074 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=81e1214db9b70523c4166e4f9072db20c2ba34ca |
||||||
Whiteboard: | |||||||
Attachments: |
|
Description
Brian de Alwis
2012-03-13 13:35:16 EDT
Committed as http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=8d04316308bc6f0fd2daf03b601c5c377fe4dc5b *** Bug 373988 has been marked as a duplicate of this bug. *** The LegacyIDE.e4xmi files in the org.eclipse.ui.workbench bundles of eclipse 4.3 and 4.4 contain the entry 'label="%trimmedwindow.label.eclipseSDK"' again, so the window title of my rcp app contains the text "%trimmedwindow.label.eclipseSDK". Any ideas? New Gerrit change created: https://git.eclipse.org/r/43074 Thanks for pointing at this, Torsten. I just had a look at the git history and figured out that Paul has added the label again within this commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=8f2a2860a007b7321d03dcae23bb10941a12ffea Maybe by accident. So I add Paul here, but also directly provide a patch for this. (https://git.eclipse.org/r/43074) Sorry if I added that back. I'll push the change on Monday if no one gets to it first. That probably got in because there are 2 of those files (the one in o.e.ui.workbench is a backup). Can you check both? The other should be in platform/eclipse.platform.git PW (In reply to Paul Webster from comment #6) > That probably got in because there are 2 of those files (the one in > o.e.ui.workbench is a backup). Can you check both? Actually, the second one in eclipse.platform is supposed to have the label, so that's OK PW Gerrit change https://git.eclipse.org/r/43074 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=81e1214db9b70523c4166e4f9072db20c2ba34ca Thanks Simon. |