Bug 365343

Summary: Use new IScriptResolver API during source lookup
Product: [WebTools] JSDT Reporter: Michael Rennie <Michael_Rennie>
Component: DebugAssignee: Michael Rennie <Michael_Rennie>
Status: RESOLVED FIXED QA Contact: Michael Rennie <Michael_Rennie>
Severity: normal    
Priority: P3 CC: hernanpepe, polomm, thatnitind
Version: 3.4Keywords: noteworthy
Target Milestone: 3.4 M5   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Bug Depends on:    
Bug Blocks: 367806    
Attachments:
Description Flags
fix
none
better fix
none
even better none

Description Michael Rennie CLA 2011-12-01 12:55:45 EST 
With the new API to help resolve remote <-> local scripts we can delegate finding local resources to contributors. This can greatly speed up source lookup. 

We should use the new API first and if no resolvers can return the local file(s) we can fall back to the 'old' way of finding source.
Comment 1 Michael Rennie CLA 2011-12-01 15:16:00 EST 
Created attachment 207809 [details]
fix

The patch adds a call into our source lookup scheme that consults script resolvers prior to trying to find the script source by search the source lookup path.
Comment 2 Michael Rennie CLA 2011-12-01 15:45:13 EST 
Created attachment 207810 [details]
better fix

Here is an updated fix for a CCE I was getting and adds support for script nodes as well.
Comment 3 Michael Rennie CLA 2011-12-05 13:31:34 EST 
Created attachment 207939 [details]
even better

This fix is event better as it has a fix for the NPE Hernan found (thanks Hernan).
Comment 4 Michael Rennie CLA 2011-12-19 11:31:33 EST 
The third patch has been applied to HEAD