Summary: | Role-side callin guard predicate interferes with Team.isExecutingCallin() | ||||||
---|---|---|---|---|---|---|---|
Product: | [Tools] Objectteams | Reporter: | Stephan Herrmann <stephan.herrmann> | ||||
Component: | OTJ | Assignee: | Stephan Herrmann <stephan.herrmann> | ||||
Status: | VERIFIED FIXED | QA Contact: | |||||
Severity: | normal | ||||||
Priority: | P3 | CC: | laze1989 | ||||
Version: | 2.0 | ||||||
Target Milestone: | 2.0.1 | ||||||
Hardware: | Other | ||||||
OS: | Linux | ||||||
Whiteboard: | Also released in 2.1 M1 | ||||||
Attachments: |
|
Description
Stephan Herrmann
2011-08-09 09:06:42 EDT
Created attachment 201140 [details]
test & fix
Analysis showed that the exception handler by which the isExecuting
flag is reset had too short a range.
The patch fixes this by putting more generated statements inside
the generated try block instead of the top-level list of statements.
Released for 2.0.1 as r1822/23. Verified for 2.0.1 using build 201108160141. This bug happens again. Needs to be reopened. (In reply to Lars Schuetze from comment #4) > This bug happens again. Needs to be reopened. Can you provide steps to reproduce? It fails in hudson https://hudson.eclipse.org/objectteams/job/buildAndTest/158/#showFailuresLink and also on my local machine. Just execute the current test cases out of the master branch. org.eclipse.objectteams.otdt.tests.otjld.teamactivation.Predicates.test914_bindingPredicate22 - 1.5 org.eclipse.objectteams.otdt.tests.otjld.teamactivation.Predicates.test914_bindingPredicate22 - 1.6 org.eclipse.objectteams.otdt.tests.otjld.teamactivation.Predicates.test914_bindingPredicate22 - 1.7 org.eclipse.objectteams.otdt.tests.otjld.teamactivation.Predicates.test914_bindingPredicate22 - 1.8 (In reply to Lars Schuetze from comment #6) > It fails in hudson > https://hudson.eclipse.org/objectteams/job/buildAndTest/158/#showFailuresLink > and also on my local machine. Just execute the current test cases out of the > master branch. > > org.eclipse.objectteams.otdt.tests.otjld.teamactivation.Predicates.test914_bindingPredicate22 > - 1.5 > org.eclipse.objectteams.otdt.tests.otjld.teamactivation.Predicates.test914_bindingPredicate22 > - 1.6 > org.eclipse.objectteams.otdt.tests.otjld.teamactivation.Predicates.test914_bindingPredicate22 > - 1.7 > org.eclipse.objectteams.otdt.tests.otjld.teamactivation.Predicates.test914_bindingPredicate22 > - 1.8 Ah, thanks for reminding me. We already have bug 469768 for that... And the full list of failures is handled via bug 484164. |