Bug 288148

Summary: [perfs] Comments applied for performance tests may be obsolete
Product: [Eclipse Project] JDT Reporter: Frederic Fusier <frederic_fusier>
Component: CoreAssignee: Olivier Thomann <Olivier_Thomann>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: Olivier_Thomann
Version: 3.6   
Target Milestone: 3.6 M2   
Hardware: PC   
OS: Windows Vista   
Whiteboard:
Bug Depends on:    
Bug Blocks: 288122    
Attachments:
Description Flags
Proposed fix none

Description Frederic Fusier CLA 2009-08-31 11:58:45 EDT 
Looking at code in HEAD today, I can see several performance tests referencing
the Performance.setComment(...) method:

1) FullSourceWorkspaceModelTests.testInitJDTPlugin():

The comment says:
"Added clean-up of internal thread local which imply additional garbage collect during the restart. It concerns only the performance test itself and has no impact in standard Eclipse usage..."

I think this comment should be removed for 3.6 performance tests it refers to a change done between 3.4 and 3.5.


2) FullSourceWorkspaceCompletionTests.testPerfCompleteMemberAccess():

The comment says:
"Regression introduced to fix bug 250454"

As bug 250454 has been fixed in 3.5, the regression should no longer appear in 3.6 performance tests, hence this comment should be removed.
Comment 1 Frederic Fusier CLA 2009-08-31 11:59:03 EDT 
Note that there's also two other commented tests in:
 - FullSourceWorkspaceModelTests.testSeekPackageFragments()
 - FullSourceWorkspaceSearchTests.testSearchMethod()

But these comments say that there's a problem of stability, I guess they may be still accurate and so cannot be removed until more investigation is done...
Comment 2 Olivier Thomann CLA 2009-09-14 14:38:08 EDT 
I entered bug 289385 to take care of the comment 1.
Removed the comments reported in comment 0.
Comment 3 Olivier Thomann CLA 2009-09-14 14:40:00 EDT 
Created attachment 147128 [details]
Proposed fix
Comment 4 Kent Johnson CLA 2009-09-15 11:43:52 EDT 
Verified for 3.6M2