Bug 248387

Description Soichiro Yoshimura 2008-09-24 02:51:23 EDT

Build ID: I20080617-2000

Steps To Reproduce:
GridItem have a number of not garbage collected fields caused by cross references.

Please fix dispose method of GridItem.

GridItem dispose() line: 287-
:::::::::FROM:::::::::::

/**
     * {@inheritDoc}
     */
    public void dispose()
    {
        if (!parent.isDisposing())
        {
            parent.removeItem(this);
     
            if (parentItem != null)
            {
                parentItem.remove(this);
            }
            else
            {
                parent.removeRootItem(this);
            }
    
            for (int i = children.size() - 1; i >= 0; i--)
            {
                ((GridItem)children.get(i)).dispose();
            }
        }
        super.dispose();

:::::::::TO:::::::::::

   /**
     * {@inheritDoc}
     */
    public void dispose()
    {
        if (parent != null && !parent.isDisposing())
        {
            parent.removeItem(this);
     
            if (parentItem != null)
            {
                parentItem.remove(this);
                parentItem = null;
            }
            else
            {
                parent.removeRootItem(this);
            }

            {
	            for (int i = children.size() - 1; i >= 0; i--)
	            {
	                ((GridItem)children.get(i)).dispose();
	            }
	            
	            children.clear();
	            children = null;
            }
            
            {
            	backgrounds.clear();
            	backgrounds = null;
            	
            	foregrounds.clear();
            	foregrounds = null;
            	
            	grayeds.clear();
            	grayeds = null;
            	
            	checks.clear();
            	checks = null;
            	
            	checkable.clear();
            	checkable = null;
            	
            	columnSpans.clear();
            	columnSpans = null;
            	
            	images.clear();
            	images = null;
            	
            	texts.clear();
            	texts = null;
            	
            	tooltips.clear();
            	tooltips = null;
            }
            
            parent = null;
        }
        
        super.dispose();
    }


More information: