Bugzilla – Full Text Bug Listing
| Summary: | [Dialogs] Adding content to "Compare with Other" dialog from Open Resource dialog | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Aleksandra Wozniak <aleksandra.k.wozniak> | ||||||||||
| Component: | Compare | Assignee: | Platform-Compare-Inbox <platform-compare-inbox> | ||||||||||
| Status: | ASSIGNED --- | QA Contact: | |||||||||||
| Severity: | enhancement | ||||||||||||
| Priority: | P3 | CC: | aleksandra.k.wozniak, benno.baumgartner | ||||||||||
| Version: | 3.4 | ||||||||||||
| Target Milestone: | --- | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| Whiteboard: | |||||||||||||
| Bug Depends on: | 73923, 239959, 244623 | ||||||||||||
| Bug Blocks: | 224562 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Aleksandra Wozniak
Created attachment 109662 [details]
patch #1
The simplest solution.
I know you're planning to add other buttons to the dialog, but at this moment wouldn't simple "Browse..." be enough? Ola, could you update the patch? Or do you want me to do it? Today it will be done. Since a small but important bug was found (see bug 244623) update will be done when 244623 is resolved. Created attachment 110434 [details]
patch #2
Created attachment 111179 [details] patch #3 Based on latest changes from bug 73923. Browsing workspace via OpenResourceDialog is now possible. Click Browse... for the Workspace option and then click Cancel on the dialog. You'll get the following error: java.lang.NullPointerException at org.eclipse.compare.internal.CompareWithOtherResourceDialog$WorkspaceContent.setResource(CompareWithOtherResourceDialog.java:308) at org.eclipse.compare.internal.CompareWithOtherResourceDialog$1.widgetSelected(CompareWithOtherResourceDialog.java:275) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:228) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1003) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3841) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3439) at org.eclipse.jface.window.Window.runEventLoop(Window.java:825) at org.eclipse.jface.window.Window.open(Window.java:801) at org.eclipse.compare.internal.ResourceCompareInput.showCompareWithOtherResourceDialog(ResourceCompareInput.java:238) at org.eclipse.compare.internal.ResourceCompareInput.setSelection(ResourceCompareInput.java:208) at org.eclipse.compare.internal.CompareAction.run(CompareAction.java:37) at org.eclipse.compare.internal.CompareWithOtherResourceAction.run(CompareWithOtherResourceAction.java:28) at org.eclipse.compare.internal.BaseCompareAction.run(BaseCompareAction.java:26) at org.eclipse.ui.internal.handlers.ActionDelegateHandlerProxy.execute(ActionDelegateHandlerProxy.java:289) at org.eclipse.core.commands.Command.executeWithChecks(Command.java:476) at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:508) at org.eclipse.ui.internal.handlers.HandlerService.executeCommand(HandlerService.java:169) at org.eclipse.ui.internal.keys.WorkbenchKeyboard.executeCommand(WorkbenchKeyboard.java:472) at org.eclipse.ui.internal.keys.WorkbenchKeyboard.press(WorkbenchKeyboard.java:824) at org.eclipse.ui.internal.keys.WorkbenchKeyboard.processKeyEvent(WorkbenchKeyboard.java:882) at org.eclipse.ui.internal.keys.WorkbenchKeyboard.filterKeySequenceBindings(WorkbenchKeyboard.java:571) at org.eclipse.ui.internal.keys.WorkbenchKeyboard.access$3(WorkbenchKeyboard.java:512) at org.eclipse.ui.internal.keys.WorkbenchKeyboard$KeyDownFilter.handleEvent(WorkbenchKeyboard.java:127) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84) at org.eclipse.swt.widgets.Display.filterEvent(Display.java:1187) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1002) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1027) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1012) at org.eclipse.swt.widgets.Control.traverse(Control.java:3499) at org.eclipse.swt.widgets.Control.translateMnemonic(Control.java:3343) at org.eclipse.swt.widgets.Composite.translateMnemonic(Composite.java:1064) at org.eclipse.swt.widgets.Control.translateMnemonic(Control.java:3361) at org.eclipse.swt.widgets.Display.translateMnemonic(Display.java:4362) at org.eclipse.swt.widgets.Display.filterMessage(Display.java:1201) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3435) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2382) at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2346) at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2198) at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:493) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:288) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:488) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149) at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:113) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:193) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:370) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:549) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:504) at org.eclipse.equinox.launcher.Main.run(Main.java:1236) at org.eclipse.equinox.launcher.Main.main(Main.java:1212) *** Bug 248300 has been marked as a duplicate of this bug. *** Created attachment 117987 [details]
patch #4
Synchronized with latest changes in repository.
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. |