Bug 196878

Summary:

[Manifest][Editors] Make "Edit..." button on "Extensions" page disappear

Product:

[Eclipse Project] PDE

Reporter:

Mike Pawlowski <mike.pawlowski>

Component:

Assignee:

Adam Archer <agarcher>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

wassim.melhem

Version:

3.3

Keywords:

contributed

Target Milestone:

3.4 M1

Flags:

mike.pawlowski: review? (wassim.melhem)

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
patch	none
patch	none

Description Mike Pawlowski

2007-07-17 16:22:34 EDT

I'd like to move the "Edit..." button on the "Extensions" page to be the last button beside the tree viewer (under "Down" button) and set its visibility to false when it is not applicable.  As far as I know no one in the Eclipse SDK makes use of it.

Subject to Wassim's veto.  Wassim, if you agree that this bug is valid, could you provide background information and any additional requirements?

Comment 1 Wassim Melhem

2007-07-17 16:28:05 EDT

It is confusing that it is always disabled in the sdk, however it has real users out there for eclipse-based products.

I wouldn't put it at the bottom.  I would keep it clustered with Add...

When invisible, it would make for a nice space in the big ladder of buttons.

Comment 2 Adam Archer

2007-07-25 12:12:12 EDT

Created attachment 74590 [details]
patch

Edit button is now invisible instead of disabled.

Also removed the existing space between the edit and up buttons to make the gap caused by the invisible button slightly smaller. This means the buttons will now be side by side when edit is visible.

Comment 3 Peter Friese

2007-07-27 03:55:39 EDT

When working on bug #194529, I also found the disabled button very confusing. What are the use cases for this button? When will it ever be enabled? Is there any hint in the online help that one can use this button?

Many questions...

Anyway, since it only seems to be relevant for a limited number of users, I'd welcome if the patch supplied by Adam would make it into the next milestone.

Comment 4 Wassim Melhem

2007-07-27 10:12:22 EDT

Adam, the Up/Down button enablement is screwed up with this patch.

Comment 5 Adam Archer

2007-07-30 11:45:46 EDT

Created attachment 74939 [details]
patch

This mistake made me sad.

All better.

Comment 6 Wassim Melhem

2007-07-30 13:36:00 EDT

Patch released.  Thanks Adam.