Bug 191599

Summary:	Shells should use host encoding
Product:	[Tools] Target Management	Reporter:	Kushal Munir <kmunir>
Component:	RSE	Assignee:	David McKnight <dmcknigh>
Status:	RESOLVED FIXED	QA Contact:	Martin Oberhuber <mober.at+eclipse>
Severity:	normal
Priority:	P3	CC:	mober.at+eclipse
Version:	2.0
Target Milestone:	2.0.1
Hardware:	PC
OS:	Windows XP
Whiteboard:
Bug Depends on:	204744
Bug Blocks:	196301

Description Kushal Munir

2007-06-07 17:54:15 EDT

Shell encoding should honor the host encoding set in the property page of the host or retrieved automatically from the remote system, i.e. it should use IHost.getEncoding(), to interpret shell output. Previously, there was a property page for Shells where users could set the encoding but it was not used.

See bug 179937 for more details.

Comment 1 Kushal Munir

2007-06-07 17:55:40 EDT

Dave, we discussed this earlier so I'm assigning this to you. I think it's an important bug to fix.

Comment 2 Martin Oberhuber

2007-06-11 08:14:07 EDT

*** Bug 180202 has been marked as a duplicate of this bug. ***

Comment 3 David McKnight

2007-07-11 14:58:15 EDT

I've changed the code to make use of the host encoding - the effects local, ssh and dstore shells.

Comment 4 Martin Oberhuber

2007-07-12 11:23:48 EDT

Wouldn't the same change also be needed for Telnet? It's a clone of SSH but it looks like it TelnetHostShell doesn't observe the encoding right now.

Comment 5 David McKnight

2007-07-12 11:58:58 EDT

I've made the change for telnet now too.