Bug 110082

Summary:

[compiler] Increase compiler performance for "Remove superfluous NLS strings" warnings

Product:

[Eclipse Project] JDT

Reporter:

Frederic Fusier <frederic_fusier>

Component:

Core

Assignee:

Olivier Thomann <Olivier_Thomann>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

Keywords:

performance

Version:

3.2

Target Milestone:

3.2 M3

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Proposed improvement	none

Description Frederic Fusier

2005-09-20 15:09:53 EDT

Since v_601 we got around 15% performance regression on test
FullSourceWorkspaceASTTests#testDomAstCreationJLS2

After tracking down what happens, it appears that it was a side effect of fix
for bug 48976. COMPILER_PB_NON_NLS_STRING_LITERAL compiler setting was wrongly
still activated after running FullSourceWorkspaceBuildTests test suite and
increase DOM/AST parse time for Parser.java as there were 334 reported warnings.

Comment 1 Olivier Thomann

2005-09-20 15:13:00 EDT

I will profile this code.
I need to see where we can speed up the detection.

Comment 2 Olivier Thomann

2005-09-21 14:35:24 EDT

Created attachment 27348 [details]
Proposed improvement

This should improve slightly the performance.

Comment 3 Frederic Fusier

2005-09-21 14:58:42 EDT

I'll try to confirm your assumption with our performance tests results as soon
as I can...

Comment 4 Olivier Thomann

2005-09-28 09:44:45 EDT

Fixed and released in HEAD.
No regression tests.

Comment 5 Frederic Fusier

2005-10-30 06:56:04 EST

Verified for 3.2 M3 using build I20051025-0800: performance test
FullSourceWorkspaceASTTests#testDomAstCreationJLS2 is now correct