[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [p2-dev] URL's with spaces

Hi Thomas,

This results from an over-use of the questionable URIUtil.fromString(String) method in p2. I tried to push for an easy fix for this once - by only escaping if the URL contains invalid characters - but this fix was rejected [1]

So there is only the hard fix left: find all references to URIUtil.fromString in the p2 code, and replace them with a call to a method which doesn't break valid URLs... Hopefully someone will do this someday...

Regards
Tobias


[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=270798

> -----Original Message-----
> From: p2-dev-bounces@xxxxxxxxxxx [mailto:p2-dev-bounces@xxxxxxxxxxx] On
> Behalf Of Thomas Hallgren
> Sent: Mittwoch, 16. Juli 2014 17:27
> To: P2 developer discussions
> Subject: [p2-dev] URL's with spaces
> 
> I tried to use a URL that contained %20 (escaped space). The Eclipse
> installer fails to read the repository if I paste
> that URL into it:
> 
>   http://geppetto-
> jenkins.puppetlabs.com/job/Geppetto%20Dev/lastSuccessfulBuild/artifact/ge
> ppetto.p2.repository
> 
> If I however replace the '%20' with a space, then everything works OK. It
> seems like the installer escapes the escapes.
> 
> Is this per design? It seems a bit awkward that I cannot do "Copy Link
> Location" in the browser and then paste it into
> the installer without first manually replacing all escapes.
> 
> - thomas
> 
> _______________________________________________
> p2-dev mailing list
> p2-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe
> from this list, visit
> https://dev.eclipse.org/mailman/listinfo/p2-dev