| Re: [orion-dev] `git log` behaviour in Orion... |
Ah. So the problem is when you said "I wouldn't do this by default
since this is expensive on a repository with a long history.", I had
taken that to mean "the CLI and JGit doesn't do this by default so you
shouldn't do it either". That is why I was surprised to see the CLI
and JGit output a log with three commits instead of just one.
I see now that you simply meant "I suggest you not do this by default
in Orion" and were not making any claims as to how the CLI or JGit
behaved. Is this correct?
Regards,
Remy
On Tue, Apr 11, 2017 at 5:25 PM, Matthias Sohn <matthias.sohn@xxxxxxxxx> wrote:
> On Tue, Apr 11, 2017 at 6:40 AM, Remy Suen <remy.suen@xxxxxxxxx> wrote:
>>
>> Hi Matthias,
>>
>> Thank you for your feedback.
>>
>> > On Wed, Apr 5, 2017 at 4:32 PM, Matthias Sohn <matthias.sohn@xxxxxxxxx>
>> > wrote:
>> >> On Wed, Apr 5, 2017 at 1:14 AM, Remy Suen <remy.suen@xxxxxxxxx> wrote:
>> >> 1. Should Orion try to track renames? If yes, should this be on by
>> >> default or toggled by the user?
>> >
>> >
>> > I think this should be on by default, in EGit we have an option to
>> > switch it
>> > off
>> > though I never used this option
>>
>> I have reopened bug 401714 for this.
>> https://bugs.eclipse.org/bugs/show_bug.cgi?id=401714
>>
>> >> 2. Should Orion try to track readds? If yes, should this be on by
>> >> default or customized by the user?
>> >
>> >
>> > I wouldn't do this by default since this is expensive on a repository
>> > with a long history.
>>
>> I agree. So I decided to try the following...
>>
>> create file test.txt + commit
>> delete file test.txt + commit
>> create file test2.txt + commit
>> change test2.txt + commit (100 times)
>> create file test.txt
>>
>> Then I ran `git log test.txt` from the CLI and it showed me three
>> commits, ADD, DELETE, ADD. I tried this with Orion connected to the
>> Java server and it also did the same thing.
>>
>> I guess by default both the CLI and JGit will "go all the way"?
>> Perhaps 100 is not enough? Perhaps I need 10,000? 1,000,000? Hm...
>
>
> I am not sure what you are expecting here ?
>
> _______________________________________________
> orion-dev mailing list
> orion-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/orion-dev
_______________________________________________
orion-dev mailing list
orion-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/orion-dev