[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [ease-dev] code contributions that are purely cosmetics
|
Hi Jonah,
we did add coding rules and save actions to all projects as project
settings some months ago. I guess we should have done auto formatting
for all projects at the same time. Would have been nicer.
For the sake of simplicity I do not revert any code changes done due to
these rules and commit them with whatever change I currently do. Same
goes for trivial doc fixes or additions.
We also used 'm' as field qualifier in the beginning of EASE and changed
to 'f' after some time as this is used by the majority of other projects
I know. Also these changes will be fixed silently with other commits.
If you are ok with that procedure, we can go on like that, so don't
revert whatever formatting gets automatically applied. Another option
would be to open a dedicated bug and apply reformatting to the whole
codebase. Would love to stick to the rule to have bug numbers on each
commit though.
Christian
On 31.05.2017 19:22, Jonah Graham wrote:
Hi Christian/Ease-dev,
What is the policy for contributing code changes that are purely cosmetic?
At the moment it seems everytime I save a file I get random unrelated
code changes. The changes seem to be mostly (all?) converting
anonymous inner classes to lambdas.
As a result everything I am doing is taking unnecessarily longer.
1) Make a change, test it, etc
2) Commit change
3) Realise a bunch of unrelated changes have slipped in to my change
4) Revert my change
5) Reformat file I am about to edit
6) Commit that file -- What to commit this against, I fell afoul of
the rules earlier by titling this Cosmetics with the Bug number. The
Eclipse Platform (most strict place I know) do allow cosmetic changes
with no bug number and actually insist on no bug number in such cases.
6) Re-apply my change (hoping there are no code conflicts, at least
there hasn't been anything too bad yet)
7) Submit my change
Thanks for your time on this (seemingly) minor issue.
~~~
Jonah Graham
Kichwa Coders Ltd.
www.kichwacoders.com
_______________________________________________
ease-dev mailing list
ease-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/ease-dev
