Bug 583215 - [Drag and drop] External Drag and drop sources are recognized as tab
Summary: [Drag and drop] External Drag and drop sources are recognized as tab
Status: UNCONFIRMED
Alias: None
Product: Efxclipse
Classification: Technology
Component: Runtime (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-30 08:54 EDT by Colin H. CLA
Modified: 2024-04-30 08:59 EDT (History)
0 users

See Also:


Attachments
The visual indicator shows on dragging a windows folder onto the position (11.54 KB, image/png)
2024-04-30 08:54 EDT, Colin H. CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Colin H. CLA 2024-04-30 08:54:15 EDT
Created attachment 289374 [details]
The visual indicator shows on dragging a windows folder onto the position

After dragging a tab for the first time, every other drag and drop item is identified as a tab.

Steps to reproduce:
1. Create an efxclipse application with Part Containers and Parts
2. Import Addon: bundleclass://org.eclipse.fx.ui.workbench.renderers.base/org.eclipse.fx.ui.workbench.renderers.base.addons.DnDAddon
3. Start application
4. Move one tab once with DND
5. Open Windows File Explorer and drag file to the tab stack
6. Drop the file
7. The last dragged tab is dragged to the position
Comment 1 Colin H. CLA 2024-04-30 08:59:34 EDT
I did a bit of debugging and it is possibly within the org.eclipse.fx.ui.controls.tabpane.skin.DndTabPaneSkinHooker.
Here the static variable DRAGGED_TAB is used for the identification of the dragged tab. This variable is never set to null, when a drag and drop ends, which leads to the drag and drop action being applied to every draged object besides the needed element.
Setting the variable DRAGGED_TAB to null at the end of tabPane_handleDragDone might solve the problem.