Bug 461725 - [Mac] Allow apps locating the configuration into Application Support
Summary: [Mac] Allow apps locating the configuration into Application Support
Status: VERIFIED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Launcher (show other bugs)
Version: 4.5.0 Mars   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: Mars M7   Edit
Assignee: Pascal Rapicault CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 431116 509087
  Show dependency tree
 
Reported: 2015-03-09 10:55 EDT by Pascal Rapicault CLA
Modified: 2016-12-12 10:15 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal Rapicault CLA 2015-03-09 10:55:58 EDT
When the Mac application will be signed, it will not be recommended for plug-ins to be directly installed in the application bundle. Instead those should be stored in ~/Application Support/<bundleId>/.
In order to obtain the proper folder, one should rely on the APIs provided by Apple, as identified in #431116#c49
Comment 1 Eclipse Genie CLA 2015-04-19 22:57:05 EDT
New Gerrit change created: https://git.eclipse.org/r/46041
Comment 2 Pascal Rapicault CLA 2015-04-19 23:07:34 EDT
I've pushed the change to
Comment 3 Pascal Rapicault CLA 2015-04-19 23:09:06 EDT
Arun, could you please push the change and build the binaries for one of the coming build? Thx.
Comment 4 Pascal Rapicault CLA 2015-04-19 23:11:08 EDT
At this point the defaults on mac is to leave the configuration folder in the Eclipse.app. If someone wants to enable the behavior where Eclipse.app is not modified and uses the Mac recommended folder, then the following command line argument needs to be specified: -protect base
Comment 5 Arun Thondapu CLA 2015-04-20 16:02:12 EDT
(In reply to Pascal Rapicault from comment #3)
> Arun, could you please push the change and build the binaries for one of the
> coming build? Thx.

Pascal, I'll try to get the recompiled binaries in time for tomorrow's I-build so that the changes can be tested more widely... the only worry is we're still building the binaries on an older version of Mac OS (10.5.8 I think) and I hope the build will go smoothly.
Comment 6 Pascal Rapicault CLA 2015-04-20 16:14:31 EDT
Hi Arun, thanks for the follow up.
Comment 8 Arun Thondapu CLA 2015-04-21 08:22:22 EDT
(In reply to Arun Thondapu from comment #5)
> (In reply to Pascal Rapicault from comment #3)
> > Arun, could you please push the change and build the binaries for one of the
> > coming build? Thx.
> 
> Pascal, I'll try to get the recompiled binaries in time for tomorrow's
> I-build so that the changes can be tested more widely... the only worry is
> we're still building the binaries on an older version of Mac OS (10.5.8 I
> think) and I hope the build will go smoothly.

I've reviewed and committed this patch but the binaries are not rebuilt yet as the hudson machine we use to manage native builds of SWT and Launcher has been having an SSH connection issue with git.eclipse.org since yesterday. We're still working on finding a solution for this problem but I don't have an ETA yet as the lab operations team needs to be involved...

David, may be we can have a respin of the I-build tomorrow assuming the connectivity issue is resolved and things are back in good shape?
Comment 9 David Williams CLA 2015-04-21 09:00:14 EDT
(In reply to Arun Thondapu from comment #8)

> David, may be we can have a respin of the I-build tomorrow assuming the
> connectivity issue is resolved and things are back in good shape?

Yep, any time.
Comment 10 Pascal Rapicault CLA 2015-04-21 09:50:09 EDT
Thanks Arun.
Comment 11 Pascal Rapicault CLA 2015-04-22 09:35:54 EDT
Patch pushed to master.
Comment 12 Arun Thondapu CLA 2015-04-22 13:53:23 EDT
Binaries rebuilt and committed via https://git.eclipse.org/c/equinox/rt.equinox.binaries.git/commit/?id=389045f6ad0fc555d2a42a63d70aa627df63e670

(In reply to Pascal Rapicault from comment #4)
> At this point the defaults on mac is to leave the configuration folder in
> the Eclipse.app. If someone wants to enable the behavior where Eclipse.app
> is not modified and uses the Mac recommended folder, then the following
> command line argument needs to be specified: -protect base

Pascal, you're probably on it already, but shouldn't this new option and default behavior be highlighted in the N&N as well as in the help documentation for Mars?
Comment 13 Gunnar Wagenknecht CLA 2016-12-12 10:12:11 EST
old summary: [Mac] Default the configuration to Application Support

I changed the summary to better reflect the outcome of this bug. It's not currently the default.
Comment 14 Gunnar Wagenknecht CLA 2016-12-12 10:12:42 EST
Verified with Neon.2 RC4 SDK build.
Comment 15 Gunnar Wagenknecht CLA 2016-12-12 10:15:11 EST
(In reply to Arun Thondapu from comment #12)
> Pascal, you're probably on it already, but shouldn't this new option and
> default behavior be highlighted in the N&N as well as in the help
> documentation for Mars?

This never happened. I've opened bug 509087 as follow up work.