Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
RE: [wtp-incubator-dev] JAX-WS Contribution. Next Steps.

Hi Shane,

 

Here is the purpose of the four layers:

-          runtime – contains some very basic functionality, e.g. calling JAX-WS APIs

-          core – contains the “business logic”. Here comes all the commands related stuff – commands themselves, WSDL analysis, eclipse resources management, etc; depends on “runtime”

-          ui – contains UI components – mainly dialogs and widgets; depends on “core” and “runtime”

-          integration – puts everything together. Here you have extension point contributions, implementation of the very web service runtimes, widget factories, commands to widget bindings, etc; depends on “runtime”, “core” and “ui”

I have to admit that the separation between “runtime” and “core” is in certain cases unclear and in my team we are sometimes wondering whether some implementation belongs to “runtime” or “core”

 

There is one additional point on the “sapnw” plugin name fragment. Our implementation is JAX-WS compliant and therefore the web service artifacts it creates should be deployable on every JEE5 application server. Therefore in case you consider to be more appropriate, I could remove the “sapnw” fragment and to call the plugins for example “org.eclipse.jst.ws.jaxws.ui”. The web service runtime could be simply called “JAX-WS”…

 

Danail

 

From: wtp-incubator-dev-bounces@xxxxxxxxxxx [mailto:wtp-incubator-dev-bounces@xxxxxxxxxxx] On Behalf Of shane clarke
Sent: Tuesday, June 16, 2009 10:12 PM
To: wtp-incubator-dev@xxxxxxxxxxx
Subject: [LIKELY JUNK]RE: [wtp-incubator-dev] JAX-WS Contribution. Next Steps.

 

Hi Danail,

> With regards to the naming discussion I would propose the following convention:
> - org.eclipse.jst.ws.jaxws.dom.* for all plugins which deal with the JAX-WS model
> - org.eclipse.jst.ws.jaxws.sapnw.* for the WS client/provider implementation

That's ok with me.

>  It is also worth mentioning that our current implementation is generally separated in four layers – runtime, core, ui, integration.
>  In case this separation is kept, the contributed plugins will have the following names:
> -   runtime - org.eclipse.jst.ws.jaxws.dom.runtime, org.eclipse.jst.ws.jaxws.sapnw.runtime
> -  core - org.eclipse.jst.ws.jaxws.dom.core, org.eclipse.jst.ws.jaxws.sapnw.core
> -  ui - org.eclipse.jst.ws.jaxws.dom.ui, org.eclipse.jst.ws.jaxws.sapnw.ui
> -  integration - org.eclipse.jst.ws.jaxws.dom.integration, org.eclipse.jst.ws.jaxws.sapnw.integration

I'm trying to get an idea of how everything is structured when compared to the existing runtimes.

>From the plug-in names, would i be right in saying that the web service creation framework extension points (org.eclipse.jst.ws.consumption.ui.*) can be found in the org.eclipse.jst.ws.jaxws.sapnw.runtime plug-in.
The commands in the org.eclipse.jst.ws.jaxws.sapnw.core plug-in and the UI widgets (org.eclipse.wst.command.internal.env.ui.widgets.SimpleWidgetDataContributor, org.eclipse.wst.command.internal.env.ui.widgets.INamedWidgetContributorFactory) in the org.eclipse.jst.ws.jaxws.sapnw.ui plug-in.

The org.eclipse.wst.command.env.ui.widgetRegistry extension points would be in either the runtime or UI plug-ins.

For the intergration layer plug-ins. Could you tell me a little bit more about those.

> As far as I can see from the currently existing plugins, the practice is to name the packages in a plugin after its name. For example, in plugin org.eclipse.core.jobs contained packages are org.eclipse.core.jobs.*.

Yes that's correct. Package names within plug-ins can also contain the *internal* name segment to indicate an internal implementation package that contains no API. See http://wiki.eclipse.org/Naming_Conventions


Thanks,
Shane

Subject: RE: [wtp-incubator-dev] JAX-WS Contribution. Next Steps.
Date: Tue, 16 Jun 2009 12:37:13 +0200
From: danail.branekov@xxxxxxx
To: wtp-incubator-dev@xxxxxxxxxxx

Hello,

 

The contributed code will consists of common JAX-WS tooling and implementation which creates JAX-WS web service providers and clients

-          The common JAX-WS tooling consists of

o        Model for JAX-WS web services

o        “JAX-WS Web Services” tree node shown in the project explorer which contains all the JAX-WS related artifacts

o        Property pages for those JAX-WS artifacts

o        Validation

-          WS artifacts generation implementation consists of

o        Web service runtime plugged in the standard web service client/provider wizard

o        Commands which perform the very code generation/modification

o        User interface for configuring the generation process

o        Utility for identifying WSDL names collisions and providing JAX-WS customization files which resolve them

 

With regards to the naming discussion I would propose the following convention:

-          org.eclipse.jst.ws.jaxws.dom.* for all plugins which deal with the JAX-WS model

-          org.eclipse.jst.ws.jaxws.sapnw.* for the WS client/provider implementation

 

It is also worth mentioning that our current implementation is generally separated in four layers – runtime, core, ui, integration. In case this separation is kept, the contributed plugins will have the following names:

-          runtime - org.eclipse.jst.ws.jaxws.dom.runtime, org.eclipse.jst.ws.jaxws.sapnw.runtime

-          core - org.eclipse.jst.ws.jaxws.dom.core, org.eclipse.jst.ws.jaxws.sapnw.core

-          ui - org.eclipse.jst.ws.jaxws.dom.ui, org.eclipse.jst.ws.jaxws.sapnw.ui

-          integration - org.eclipse.jst.ws.jaxws.dom.integration, org.eclipse.jst.ws.jaxws.sapnw.integration

 

 

As far as I can see from the currently existing plugins, the practice is to name the packages in a plugin after its name. For example, in plugin org.eclipse.core.jobs contained packages are org.eclipse.core.jobs.*.

 

Are the points above OK with you?

 

Best regards, Danail

 

From: Branekov, Danail
Sent: Wednesday, June 10, 2009 11:28 AM
To: 'WTP Incubator Dev list'
Subject: RE: [wtp-incubator-dev] JAX-WS Contribution. Next Steps.

 

Hi,

 

This specific contribution deals (mainly) with the web service wizard (consumer and provider) which is bound to a specific web service runtime. This specific web service runtime will be called “SAP NetWeaver”, similarly to “Apache Axis”. This is the reason to put this coding in a separate group.

I agree with your point that it is a good idea to have the technology name (jaxws) as well. So org.eclipse.jst.ws.jaxws.sapnw.* is a good option, right?

 

Regards, Danail

 

From: wtp-incubator-dev-bounces@xxxxxxxxxxx [mailto:wtp-incubator-dev-bounces@xxxxxxxxxxx] On Behalf Of Nitin Dahyabhai
Sent: Wednesday, June 10, 2009 11:10 AM
To: wtp-incubator-dev@xxxxxxxxxxx
Subject: RE: [wtp-incubator-dev] JAX-WS Contribution. Next Steps.

 


Maybe I'm overlooking something, but why would the group be named after any specific adopter's IDE instead of the technology (e.g. wst.xsl and jst.jsp) or standards implementation (e.g. server.tomcat, server.geronimo) it supports?  Wouldn't org.eclipse.jst.ws.jaxws.* be the logical choice, hyphenation aside?

Regards,
---
Nitin Dahyabhai
Eclipse WTP Source Editing
IBM Rational

"Branekov, Danail" <danail.branekov@xxxxxxx>
Sent by: wtp-incubator-dev-bounces@xxxxxxxxxxx

06/10/2009 03:17 AM

Please respond to
WTP Incubator Dev list <wtp-incubator-dev@xxxxxxxxxxx>

To

"WTP Incubator Dev list" <wtp-incubator-dev@xxxxxxxxxxx>

cc

 

Subject

RE: [wtp-incubator-dev] JAX-WS Contribution. Next Steps.

 

 

 




Hi Shane,
 
I am about to start working on our source code contribution. As a starting point, I would like to ask you how you would prefer to structure the source code which you would receive. I checked the JST plugins – the AXIS(2) plugins are grouped in sets with names org.eclipse.jst.ws.axis.* and org.eclipse.jst.ws.axis2.*. In my opinion, it makes sense our implementation to be put in a new group, maybe called something like “org.eclipse.jst.ws.sapnw”. “sapnw” stands for “SAP NetWeaver” which is the name of the SAP product which the eclipse based IDE is shipped within.
 
Thanks!
 
Regards, Danail
 

 


From: wtp-incubator-dev-bounces@xxxxxxxxxxx [mailto:wtp-incubator-dev-bounces@xxxxxxxxxxx] On Behalf Of shane clarke
Sent: Thursday, April 02, 2009 10:42 AM
To: wtp-incubator-dev@xxxxxxxxxxx
Subject: [LIKELY JUNK][wtp-incubator-dev] JAX-WS Contribution. Next Steps.
 
Hi Hristo, Danail

Following the meeting summary the next steps to proceed with the JAX-WS contribution are:

  • SAP AG needs to open an Eclipse bugzilla entry attaching the code to be contributed along with some additional information (see below).
  • A technical review of the code will need to be done.
  • The PMC will need to approve of the content’s suitability.
  • Followed by submitting a CQ (Contribution Questionnaire) to Eclipse legal requesting the Parallel IP process. Eclipse legal will review the submission and if they're satisfied with it they'll grant preliminary legal approval. This will allow the code to be checked into CVS. Eclipse Legal will continue their due diligence review in parallel and this must be completed before the code is included in a release.


For the Eclipse.org bugzilla entry go to https://bugs.eclipse.org/bugs
Select “Enter an enhancement feature request”
Product : WTP Incubator
Component : wtp.inc.jaxws

The contribution should be attached as a zip file containing the features and/or plug-ins.

In order to do a technical review of the code we'll need the version of Eclipse, WTP and any other required dependencies that are used. Plus any additional instructions that are needed to get it up and running.

There is some work that will need to be done before submitting a CQ and checking the code into CVS including:

  • Removing/Replacing the internal API's used by the JAX-WS runtime.
  • Check that all contributed files (.java, .xml, .properties, etc...) have a copyright statement.
  • Renaming the contributed features and plug-ins, package names to org.eclipse. Axis, Axis2 and CXF use the org.eclipse.jst.ws namespace.


Additional information to include in the bugzilla entry:

  •  A description of the contribution including any related information on intellectual property rights (patents, trademarks, etc..).  Was it written entirely within SAP AG.  Does it incorporate content from elsewhere or rely on the IP of others.
  •  Source of the contribution, where it's coming from e.g. was it part of a commercial product.
  •  If you are authorized by your employer to make the contribution.
  •  Need to identify all applicable licenses. Is it EPL based?
  •  A list of any 3rd party dependencies.
  •  A list of any graphics or icons contained within the contribution and their source e.g. created internally by SAP AG, copied from another plug-in within Eclipse.
  •  Does any of the code in the contribution deal in any way with cryptography.
  •  Contact details for each of the contributors: name, organization, email address and/or phone number, percent of contribution authored.
  • The name(s) of any committer(s) to nominate that will work on the JAX-WS component (integration, maintenance/bug fixes).


I'm here to help with any questions you might have.

Thanks,
Shane

 


Get the next generation of Free Windows Live Services Click here!_______________________________________________
wtp-incubator-dev mailing list
wtp-incubator-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/wtp-incubator-dev

 

Free upgrade for your Windows Live Messenger! Click here!

Back to the top