[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [wtp-dev] JSDT facet gone missing in 3.0.4?


Well now you're dealing from the fallout of behavior where non-critical errors are flooding the Error Log despite nothing being really wrong. Some other people had previously complained about the flooding of the Error Log in similar situations in the past and "some discussion" ensued, but no changes were made. Now you're dealing with the fallout of the exact same problem and your solutions / suggestions include either changing a large number of plugin.xml files or re-instating a deprecated extension point (even if it does nothing) simply so that your framework doesn't flood the error log.

I'm not trying to be crude or rude here (forgive me, I *am* from NYC), but others had complained about the behavior, were ignored, and your solutions don't seem to address the actual issue. The plugin.xml files shouldn't have to change. The old facet should not need to be re-instated. Your framework just shouldn't complain so much, and if it must, it should do it via Trace.
I must disagree for this one ;) The poor handling is about the JSDT; it should either not have been added in the first place or not removed before 3.1 or removed completely and not half-done as here.

I agree with Konstantin that getting warnings/errors about bad configuration is better than ignoring it by default.
The solution for this would be that you could mark things explicitly as optional/don't error or somehow let JSDT or a seperate plugin state it want to be part of the aggregation(?)


In any case, what is 3.0.4 adopters supposed to do with this bug ? Is there anything we can do to fix it ?
We got a release coming up in March and would like to use 3.0.4 but want to be sure we don't flood users logs
with these messages.
Looking at this again - then if the only thing the facet framework is doing is logging that there is a missing thing which does not affect any behavior at all shouldn't this be traced instead of error'd ?
I still find it really bad JSDT didn't fix this fully, but if the fix would be to lower the logging severity isn't that a better fix ?


/max

/max



-----Original Message-----
From: Rob Stryker [mailto:rob.stryker@xxxxxxxxxx] Sent: Tuesday, February 03, 2009 8:49 PM
To: konstantin.komissarchik@xxxxxxxxxx; General discussion of project-wide or architectural issues.
Subject: Re: [wtp-dev] JSDT facet gone missing in 3.0.4?


Maybe this is just crazy talk, but perhaps a server or runtime type
expressing "support" for a facet type should not cause error messages
like this if the facet type is missing. I know, I know... I'm living in
a dream land... but in my thick empty skull I kinda have this notion
that "supporting" a facet isn't the same as requiring it.

But, I mean, I could be wrong. Maybe there's something in the China
water messing with my head. Crazy talk. ... Crazy.

;)

- Rob Stryker

Konstantin Komissarchik wrote:
I just double-checked and despite what is said in Bug 243183, the JSDT facet is present in Ganymede SR1 (3.0.2) and in 3.0.3. It has been removed in the 3.1 HEAD stream for a few months now, but the change in the maintenance stream has happened fairly recently.


surprised by the number of plugin.xmls that now have to be updated to
prevent this error message.

This was the result of the desire to have the JSDT facet on by default when a user targets one of the runtimes that has drivers shipping with WTP. This meant that this facet had to be explicitly included in all the default facet sets for all the various server types. In my opinion, this would have been much better handled by leaving the facet off by default and having some way to unobtrusively tell the user that there is additional functionality available when the user goes to certain contexts. For instance, if the user opens a javascript file or you detect javascript in an html/jsp, you could put an "Enable advance JavaScript support" banner link across the top of the editor. That's just my two cents on this.


Even if the facet is added back into 3.0.4, is/will there be a mechanism
for deprecating or automatically migrating it out of 3.1 (by M6 if that's
the course of action we decide upon)?


That depends on what behavior you are after. There is an enhancement request (Bug 255038) that was recently opened that would allow facets to be marked as deprecated. In that case you leave the facet implementation in the code base, but because it is marked as deprecated it is not visible on projects that don't have it installed already. Project metadata is not modified automatically. Other approaches are possible as well, of course.


Oracle Konstantin Komissarchik | Consulting Member of Technical Staff Phone: +1 425 945 8445 | Mobile: +1 206 898 0611 Oracle Eclipse Tooling 411 108th Ave NE, Suite 800 | Bellevue, WA 98004


-----Original Message-----
From: wtp-dev-bounces@xxxxxxxxxxx [mailto:wtp-dev-bounces@xxxxxxxxxxx] On Behalf Of Nitin Dahyabhai
Sent: Tuesday, February 03, 2009 6:17 AM
To: wtp-dev@xxxxxxxxxxx
Subject: Re: [wtp-dev] JSDT facet gone missing in 3.0.4?


Looks like it was removed in 3.0.2 through bug 243183, and at least
noticed at the latest from bug 21928, but not actually removed from the
server tools plug-ins. I regret how poorly this was handled, and am
surprised by the number of plugin.xmls that now have to be updated to
prevent this error message.


Even if the facet is added back into 3.0.4, is/will there be a mechanism
for deprecating or automatically migrating it out of 3.1 (by M6 if that's
the course of action we decide upon)?


Regards,
---
Nitin Dahyabhai
Eclipse WTP Source Editing
IBM Rational

_______________________________________________
wtp-dev mailing list
wtp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/wtp-dev

_______________________________________________
wtp-dev mailing list
wtp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/wtp-dev




_______________________________________________ wtp-dev mailing list wtp-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/wtp-dev

_______________________________________________ wtp-dev mailing list wtp-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/wtp-dev