[wtp-dev] Source Plugins in SDK builds - fixes require changes/improveme

[David M Williams <david_williams@xxxxxxxxxx>]

In order to address the bugs attached
below, I made some change to build "infrastructure" (much more
minor than it sounds) 
to get the source plugins produced correctly
in SDK builds. 

One implication of this change is that
now it will fall on component/plugin owners to make 
sure their "Source Build"
parameters are correct (previously, some stuff was automatically 
excluded and automatically included,
but this seems potentially limiting, puts responsibility in the wrong place,
and 
makes things confusing as heck). 

[Recall, the "Source Build"
checkboxes correspond 
to things in the src.include line in
the build.properties file.  This should effect only what's included
in your directory of the "source
plugin" that's part of SDK build.]

So ... the general rules are  

DO include in "src.include"
     schema folders (to
pickup "extension point" definitions
     rose folders (to
pick up EMF models)
     component.xml files.
     build.properties
     build.xml ONLY if
its a custom build.xml (I think we have only two, for docs). 
     
DO NOT include in "src.include"
     source folders themselves
(I know, life is full of irony)
     jar files 
    property/resource folders
(these should already be provided by bin.include). 
     plugin.xml (these
should already be provided by bin.include). 
     META-INF folder
(these should already be provided by bin.include). 
     manifest.mf files
(these should already be provided by bin.include). 
     .options files (this
should already be provided by bin.include)
     build.xml (unless
it is a custom build.xml file). 

    
I'm sure I'm forgetting/mistaken in
some of the above, so if anyone has in comments/suggestions, 
please let us know. (And a web contribution
to "practices" document explaining whole thing
would be appropriate). 

I believe the next nightly build (around
noon on Monday)  will be "correct" (from the changes I've
made), 
so for the builds this week, please
visually check your directories in org.eclipse.jst.source and 
org.eclipse.wst.source to see if appear
correct (include enough, don't include too much). 
And then eventually test with "import
from target, include source" and see if imported ok. 

I'd recommend this week we be on the
"honor system" for component/plugin owners to 
clean up their "src.include"
statements .. then next week opening bugs would be fair game. 

As always .. questions/comments welcome.



Thanks, 

= = = = 


93435 schema and rose models missing
in source distribution
https://bugs.eclipse.org/bugs/show_bug.cgi?id=93435

99616 SDK Source plugins lost when moved
to manifest.mf form
https://bugs.eclipse.org/bugs/show_bug.cgi?id=99616