[vtp-dev] Re: validation

[Brent D Metz <bdmetz@xxxxxxxxxx>]

I thought there was a bugzilla behind
it, but I can't find it. Since I couldn't reproduce the bug myself I took
a bit of a scorched earth policy in the existing validation code and started
speculating what could be the issue. I've seen spaces in passwords being
trimmed before so that stood out as a possibility. The fix ended up working
well by all accounts. From the followup I understand the actual tellme
password length requirements weren't what was documented. I personally
feel we should leave the user to put the wrong thing in those fields and
keep the checking to when the login is attempted.

There was a separate issue with switching
tabs that was quite subtle. It turns out that setting the tab up when you
switched back to it was throwing modify events on each input field, causing
the stored correct values on the other input fields to be overridden with
incorrect values. We never saw this on simpler examples because it works
fine with one input field, which is what my test case had. I placed a guard
variable around the modifylistener to solve the problem. The bug is at
https://bugs.eclipse.org/bugs/show_bug.cgi?id=127601

--
Brent D. Metz
Enterprise Voice Tools
bdmetz@xxxxxxxxxx
"Simple things should be simple, and complex things should be possible."
- Alan Kay

"Michael Greenawalt" <mgreenawalt@xxxxxxxxxx>

02/28/2006 09:47 PM

To	Brent D Metz/Boca Raton/IBM@IBMUS
cc
Subject	validation

Brent –
 
I was catching up on the newsgroup today.
I saw the threads on the Run button not being enabled. You changed the
validation rules. Did you file bugs to match the changes? 
 
I feel somewhat ambivalent about that change.
If we know the rules, it seems appropriate to do the check. On the other
hand, if it is wrong, it will get caught elsewhere. Studio is not a precious
resource that will be damaged by having bad logins sent to it. 
 
You made a comment in the code that the password
may have spaces on purpose – but the Studio developers tell me that spaces
are not allowed in the password. So, I am puzzled at the comment.
 
What was the issue about switching back and
forth between the tabs? You said you fixed it.
 
-- Mike