Re: [ve-dev] GridBagLayoutEditPolicy

[Peter Walker <walkerp@xxxxxxxxxx>]

Janak,
Please see my responses after your questions.

>Could you please tell me when
>GridbagLayoutEditPolicy.createChangeConstraintCommand() is called?
what user
>action is responsible for invoking it?
>
>It is not clear from the call graph or refernces.
From checking the references
to this particular method in GridBagLayoutEditPolicy, it is never called
and probably needs to be removed. It was probably left over from long ago
when GridBagLayoutPolicy was first developed and didn't have the move capability
yet.
A similar method in GridBagLayoutPolicyHelper
is used for the layout switcher (i.e. when switching from another layout
to GridBagLayout).

>However, getMoveChildrenCommand is overridden
by GridBaglayoutEditPolicy.
We overrode this to handle many special
situations that occur when moving components in this layout such as inserting
rows/columns, keeping the constraints during the move, etc..

>BTW; In ULC, since we have similar API to Swing,
we are using your code from
>BorderLayout and GridBagLayout Feedbacks. It would be helpful if this
can be
>opened up i.e. removed from internal.
Agreed... this is an ongoing effort
in VE and little by little we plan to lock down the APIs and make the packages
non "internal" to encourage others to extend the VE. Layout extension
is a fairly high priority item for opening up and supporting public APIs
but not sure when it's going to happen.

Best regards...

Peter Walker
-------------------------------------
Eclipse JVE Development
919-254-1558 - T/L 444, Fax 254-8169, HYSA/501/K107
IBM SWG at RTP, 3039 Cornwallis Rd, RTP, NC 27709
Lotus Notes: Peter Walker/Raleigh/IBM   Internet: walkerp@xxxxxxxxxx

"Janak Mulani" <janak.mulani@xxxxxxxxx>
Sent by: ve-dev-bounces@xxxxxxxxxxx

08/17/2005 11:46 AM

Please respond to
Discussions people developing code for the Visual Editor project

To	"ve-Dev@Eclipse. Org" <ve-dev@xxxxxxxxxxx>
cc
Subject	[ve-dev] GridBagLayoutEditPolicy

Hi,

Could you please tell me when
GridbagLayoutEditPolicy.createChangeConstraintCommand() is called? what
user
action is responsible for invoking it?

It is not clear from the call graph or refernces.

getMoveChildrenCommand of ConstrainedLayoutEditPolicy calls
getResizeChildrenCommand which in turn calls createChanneConstraint command.

However, getMoveChildrenCommand is overridden by GridBaglayoutEditPolicy.

BTW; In ULC, since we have similar API to Swing, we are using your code
from
BorderLayout and GridBagLayout Feedbacks. It would be helpful if this can
be
opened up i.e. removed from internal.

Thanks and regards,

Janak

-----------
Janak Mulani
Canoo Engineering AG
web: www.canoo.com
email: janak.mulani@xxxxxxxxx
tel: +91 98200 91274

ULC: Rich Internet Applications for J2EE
www.canoo.com/ulc

_______________________________________________
ve-dev mailing list
ve-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ve-dev