| Re: [tracecompass-dev] Regarding Start trace server before opening trace |
|
Hi Bernd, Thank you for your reply. We have our own server and our own extension that is already hooked to the server, with many validations conducted before starting the server. Ideally, we don't want to have to add another dependency to just boot-up/stop
the server (in our case, this would be hooking just our callback to the vscode-trace-server) as it introduces more logistical overhead to manage another extension.
We would prefer to use the external API so that our extension can provide the functionality of how/what server should be started; The advantage of the API being that it doesn't tightly couple the vscode-trace-server extension with the base
trace extension. Our proposal is to register a startServerEvent (with arguments) and stopServerEvent in the VSCode Trace Extension, adopting extension can register a listener for the startServer, stopServer and manage their version of the trace server as they
please. This will be an implementation of [1]. We would like to help with the development of this API. If you have any question, suggestion or concern about this implementation, please let me know. Thank you. Regards, Alex [1]
https://github.com/eclipse-cdt-cloud/vscode-trace-extension/pull/149 From: tracecompass-dev <tracecompass-dev-bounces@xxxxxxxxxxx>
On Behalf Of Bernd Hufmann via tracecompass-dev
Hi Alex I would like to propose the patch [1] as an intermediate solution before adding an external API to the vscode-trace-extension
for registering callbacks to start/stop of a trace server. Right now, I'd like to go ahead with this PR due to time constraints and, if needed, add the API only later. Please let me know if you are ok with this. Please let me also know if you have any concerns and if this solution would not work for your use case. Looking forward hearing from you. BR Bernd From: Bernd Hufmann <bernd.hufmann@xxxxxxxxxxxx> Hi Alex yes, we backlogged the item. Our current plan is to work on that in the coming weeks and have a proposal PR in 2-3 weeks. Expanding the API of
#149 makes
sense. We'll coordinate for that. Thanks, Bernd From: Alex Doan <vadoan@xxxxxxxxxxxxxx> hi, it seems that the feature to Start trace server before opening trace has been backlogged at
#142. I’m interested in contributing to the feature according to
@Bernd Hufmann’s review, that is to create an API that another extension can register a start and stop callback. I’m thinking to expand on the external API feature in
#149 for this. Please let me know if there’s any question, suggestion or concern. Thank you. Regards, Alex This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use
of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction
of this transmission by unintended recipients is not authorized and may be unlawful. This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful. |