| Re: [tracecompass-dev] Regarding Start trace server before opening trace |
|
Hi Alex
I would like to propose the patch [1] as an intermediate solution before adding an external API to the vscode-trace-extension for registering callbacks
to start/stop of a trace server. Right now, I'd like to go ahead with this PR due to time constraints and, if needed, add the API only later.
Please let me know if you are ok with this. Please let me also know if you have any concerns and if this solution would not work for your use case.
Looking forward hearing from you.
BR
Bernd
From: Bernd Hufmann <bernd.hufmann@xxxxxxxxxxxx>
Sent: June 21, 2023 9:24 AM To: Alex Doan <vadoan@xxxxxxxxxxxxxx>; tracecompass developer discussions <tracecompass-dev@xxxxxxxxxxx> Cc: Elena Laskavaia <ELaskavaia@xxxxxxxxxxxxxx>; Neel Gondalia <ngondalia@xxxxxxxxxxxxxx> Subject: Re: Regarding Start trace server before opening trace
Hi Alex
yes, we backlogged the item. Our current plan is to work on that in the coming weeks and have a proposal PR in 2-3 weeks. Expanding the API of
#149 makes
sense. We'll coordinate for that.
Thanks,
Bernd
From: Alex Doan <vadoan@xxxxxxxxxxxxxx>
Sent: June 20, 2023 4:49 PM To: tracecompass developer discussions <tracecompass-dev@xxxxxxxxxxx>; Bernd Hufmann <bernd.hufmann@xxxxxxxxxxxx> Cc: Elena Laskavaia <ELaskavaia@xxxxxxxxxxxxxx>; Neel Gondalia <ngondalia@xxxxxxxxxxxxxx> Subject: Regarding Start trace server before opening trace hi, it seems that the feature to Start trace server before opening trace has been backlogged at #142. I’m interested in contributing to the feature according to @Bernd Hufmann’s review, that is to create an API that another extension can register a start and stop callback. I’m thinking to expand on the external API feature in #149 for this. Please let me know if there’s any question, suggestion or concern. Thank you.
Regards,
Alex This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful. |