| [tracecompass-dev] Review process update (Minor) |
|
Hi all, we would like to propose some changes to the review process in trace compass, I have highlighted the differences here
https://diffonline.net/XGJU3mlMqZ, I hope this helps the project.
Here is the new proposed text
We will try to give feedback to new patches in a reasonable amount of time, usually in the following days. Smaller patches makes the review go faster. With the exception of “trivial patches”, as in, patches that either don’t change the compiled code (e.g., comments, commit messages), we try to have two (2) committers review every patch that goes in. For a patch from a committer, this means a second committer should review it, even for the trivial ones. For a patch from a non-committer, one committer should do a thorough review, and at least a second one should give a quick look. A committer may update the patch being submitted, then the original author must review it. This is useful if the author has minor nits to fix, e.g., spaces. For a patch to be approved, it needs to be marked as Code Review and Verified. Code Review means the patch "looks" good, it follows the coding style, uses relevant algorithms and data structures, etc. Verified in general means that the patch technically works, it compiles, the tests pass, and it does what it is supposed to do. It is possible to have a +1 Verified with a -1 Code Review, this means the code works as intended... but the implementation can be improved. The meanings of each score are listed below.
Matthew Khouzam Digital Product Owner LTTng, Theia, IDE and Trace Compass |