Re: [tm-dev] renabling JUnits?

[David McKnight <dmcknigh@xxxxxxxxxx>]

Hi Dave,

I've noticed a couple things when looking at these but, since I'm not all the familiar with the testing framework, I'm not sure what to expect here.

First, the ScpFileSubsystemTestCase.testScpAccessToRemoteHost() is failing because the "userid" in scpConnection.properties is set to "unknown" and RSEConnectionManager.findOrCreateConnection() does the following test:

String userId = properties.getProperty(IRSEConnectionProperties.ATTR_USERID);
Assert.assertFalse("FAILED(findOrCreateConnection): Invalid user id name!", "unknown".equals(userId)); //$NON-NLS-1$ //$NON-NLS-2$

Is this "userid" supposed to be set in the scpConnection.properties?


Second, when RSEFileStoreTest.testModifyNonExisting() is exercised, the following check is made to determine why the input stream can't be opened:

int code = ce.getStatus().getCode();
assertTrue("1.6.1", code == EFS.ERROR_NOT_EXISTS || code == EFS.ERROR_READ);

Right now we don't get EFS.ERROR_NOT_EXISTS nor EFS.ERROR_READ as the code but we do get EFS.ERROR_NO_LOCATION.  Should the assertTrue instead be as follows?
assertTrue("1.6.1", code == EFS.ERROR_NOT_EXISTS || code == EFS.ERROR_READ || code == EFS.ERROR_NO_LOCATION);


Finally, the other two failing cases involve SimpleCommandOperation with a null ShellSubsystem.

java.lang.NullPointerException
at org.eclipse.rse.subsystems.shells.core.model.SimpleCommandOperation.runCommand(SimpleCommandOperation.java:92)
at org.eclipse.rse.tests.subsystems.files.RSEFileStoreTest.testDeleteSpecialCases(RSEFileStoreTest.java:368)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

The thing is when I try to run the testcases from my dev environment, I never get to the SimpleCommandOperation stuff.  In my case, it doesn't get there because fHomeDirectory isn't set during the setup() calls.  I'm running this on Windows - not sure if that would make the difference.

____________________________________
David McKnight    
Phone:   905-413-3902 , T/L:  969-3902
Internet: dmcknigh@xxxxxxxxxx
Mail:       D1/YFY/8200/TOR
____________________________________



David McKnight---17/01/2013 02:48:03 PM---Hi Dave, I'll try to get to those early next week.

From:	David McKnight/Toronto/IBM@IBMCA
To:	TM project developer discussions <tm-dev@xxxxxxxxxxx>
Cc:	TM project developer discussions <tm-dev@xxxxxxxxxxx>, tm-dev-bounces@xxxxxxxxxxx
Date:	17/01/2013 02:48 PM
Subject:	Re: [tm-dev] renabling JUnits?
Sent by:	tm-dev-bounces@xxxxxxxxxxx

---

Hi Dave,

I'll try to get to those early next week.

Thanks,
____________________________________
David McKnight    
Phone:   905-413-3902 , T/L:  969-3902
Internet: dmcknigh@xxxxxxxxxx
Mail:       D1/YFY/8200/TOR
____________________________________

David Dykstal ---17/01/2013 02:21:20 PM---Anna -- Thanks for re-enabling the tests. This is excellent! Most of the tests

From:	David Dykstal <david_dykstal@xxxxxxxxxx>
To:	TM project developer discussions <tm-dev@xxxxxxxxxxx>
Date:	17/01/2013 02:21 PM
Subject:	Re: [tm-dev] renabling JUnits?
Sent by:	tm-dev-bounces@xxxxxxxxxxx

---

Anna -- 

Thanks for re-enabling the tests. This is excellent! Most of the tests that are failing seem to fall in Dave McKnight's area. 

Dave -- can you take a look? It's probably something trivial. The test failures (and successes) are here. 
https://hudson.eclipse.org/hudson/job/tm-master-nightly/833/testReport/ 

I want to have all these cleaned up by our SR2 RC2 build. That should be on or before Jan 25. 

-- David Dykstal,  Architect - Rational Developer for Power Systems_______________________________________________
tm-dev mailing list
tm-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/tm-dev

_______________________________________________
tm-dev mailing list
tm-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/tm-dev