Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[tcf-dev] [PATCH 0/2] Address warnings in TCF Agent

Hi,

I hope this is the right way to submit minor patches. If not, please
educate me.

Compiling for GCC 7.5 targetting arm-rtems, there were a couple of warnings
in the general agent source.

+ asyncreq.c has a potential buffer overflow where the return value from
  snprintf() is not checked. Looking at the two values concatenated with a
  / between them, it seemed safer to check the return value than attempt to
  make the destination buffer larger.

+ compression.c has a method declaration which is missing the word void
  between the (). GCC says this is not proper.

Thanks.

--joel

Joel Sherrill (2):
  asyncreq.c: Check return value from snprintf() for buffer overflow
  compression.c: Fix gcc not a prototype warning

 agent/tcf/framework/asyncreq.c    | 4 +++-
 agent/tcf/framework/compression.c | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)

-- 
1.8.3.1



Back to the top