Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[tcf-dev] TCF IP Log Submitted for Kepler

Hi TCF Committers and Contributors,

 

Last Friday I submitted the TCF IP Log for Kepler:

http://www.eclipse.org/projects/ip_log.php?projectid=tools.cdt.tcf

 

When reviewing the log, it turned out that I had to remove more than 100 duplicates from the log, where both the git “Author” and the “iplog+” flag on the bug had been set. I have 2 requests to simplify this moving forward:

 

1.       Please use Gerrit – Avoid Bugzilla Patches

 

Moving forward, I strongly suggest to _not_ attach patches on Bugzilla, but leverage Eclipse Gerrit instead for contributions. The Eclipse Foundation’s CLA Process (Contributor License Agreements), which will be rolled right out after Kepler, will be another step in the direction of more automation via Gerrit.

 

Contributing via Gerrit is actually as simple as a “git push review” once things are set up. I recommend using the commandline for Gerrit. Details for TCF are here – I’m going to copy these into a CONTRIBUTING.md file in the TCF Repositories very soon:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=404603#c4

 

 

2.       Include Bugzilla ID in the commit message

 

My other request is to please always include the Bugzilla Bug ID in the 1st line of your commit message. You can copy-and-paste the 1st line of a Bugzilla Web Page, then edit it to match your needs. Some examples of good commit messages:

 

-          TCF Python: Bug 372472 - Memory error handling & attached property

-          Bug 388018 - Flush context stack trace if its memory map has changed

-          Target Explorer: Bug 370524 - [TERMINALS][Serial] Add serial line support

 

As you see, the IP Log tool automatically converts references like “Bug 123456” into a hyperlink so this is the format that should be used. Other formats like “Bug [123456]” are not that good.

 

The message from Mike Milinkovich / Doug Schaefer below has some more background on the IP Log and how it’s created.

 

Thanks,

Martin

--

Martin Oberhuber, SMTS / Product Architect – Development Tools, Wind River

direct +43.662.457915.85  fax +43.662.457915.6

 

From: cdt-dev-bounces@xxxxxxxxxxx [mailto:cdt-dev-bounces@xxxxxxxxxxx] On Behalf Of Mike Milinkovich
Sent: Saturday, May 25, 2013 3:12 PM
To: cdt-dev@xxxxxxxxxxx; cdt-dev@xxxxxxxxxxx
Subject: Re: [cdt-dev] iplog policy

 

 

Just a quick FYI on your last comment about CLAs. The approvals are all done, and the whole process will be rolled out right after Kepler ships. 

 

Mike Milinkovich
mike.milinkovich@xxxxxxxxxxx
+1.613.220.3223

From: Doug Schaefer

Sent: Friday, May 24, 2013 4:40 PM

Reply To: CDT General developers list.

Subject: [cdt-dev] iplog policy

 

Hey gang, the IP log for Kepler/CDT 8.2 has now been submitted. It's always a nice trip down memory lane doing that remembering all the people who've contributed to the CDT over the years.

 

Also kudo's to Elena for the git genie which I used extensively to ensure authors were recorded correctly in git.

 

I just wanted to clarify the new iplog policy since I don't think I've said it before, even though I saw a lot of committers doing things correctly, especially lately.

 

So it really comes down to this. It is no longer necessary to mark iplog+ on anything in Bugzilla. All the necessary information is captured in git in the author field. Of course, committers, please make sure the author field is set correctly, especially if you are committing a patch for someone else. Also, please make sure you put the bug number in the first line of the comment field so that the IP log can point back to the bug. The bug is still the place to record the answer to the three questions:

 

1.    Did you author 100% of the content you’re contributing?

2.    Do you have the rights to contribute this content to Eclipse?

3.    Are you willing to contribute the content under the EPL?

At least until the CLA process gets approved and put in place.

 

Hope that helps, and thanks for all your hard work and contributions to the CDT!

 

Thanks!

Doug.




Back to the top