Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [tcf-dev] tracking TCF contributions for IP log

bug 288266

On 08/28/2012 11:22 AM, Oberhuber, Martin wrote:
Pawel,

Can you please file a bug against Community / Gerrit for investigation.

I understand that Gerrit handles all contributions in separate branches, so investigating the Gerrit internal repos our webmasters might get a clue what went wrong here. Or perhaps they can point us to some known issue of some sort.

Thanks
martin

-----Original Message-----
From: tcf-dev-bounces@xxxxxxxxxxx [mailto:tcf-dev-bounces@xxxxxxxxxxx]
On Behalf Of Tepavich, Scott
Sent: Tuesday, August 28, 2012 8:17 PM
To: TCF Development
Subject: Re: [tcf-dev] tracking TCF contributions for IP log

Hi Martin -

Thanks for the link.  I double checked my settings and they are okay.

BR -
Scott

-----Original Message-----
From: tcf-dev-bounces@xxxxxxxxxxx [mailto:tcf-dev-bounces@xxxxxxxxxxx]
On Behalf Of Oberhuber, Martin
Sent: Tuesday, August 28, 2012 11:05 AM
To: TCF Development
Subject: Re: [tcf-dev] tracking TCF contributions for IP log

Please have Scott also check his settings. Maybe he has multiple E-Mails
registered or something.

Martin

-----Original Message-----
From: tcf-dev-bounces@xxxxxxxxxxx [mailto:tcf-dev-bounces@xxxxxxxxxxx]
On Behalf Of Pawel Piech
Sent: Tuesday, August 28, 2012 7:59 PM
To: tcf-dev@xxxxxxxxxxx
Subject: Re: [tcf-dev] tracking TCF contributions for IP log

I reviewed all my settings and I still don't understand why Scott's
authorship didn't get preserved.  I checked for CDT gerrit
contributions and it seems they worked fine.  Looking at gerrit
project settings for the two, there are some differences, but nothing
specific to this.
Next time I merge a gerrit commit, I'll scrutinize the options better.
-Pawel

On 08/28/2012 10:43 AM, Pawel Piech wrote:
Thanks for the link.  I'd rather not mess with changing history, and
the IP log is correct now.

Cheers,
Pawel

On 08/28/2012 10:25 AM, Oberhuber, Martin wrote:
Hi Pawel,

Many thanks for double-checking.

Is the broken commit the most recent one ? Or fairly recent ?
Then amending the author should be possible with acceptable effort,
see the 3rd and 4th answer here:
http://stackoverflow.com/questions/750172/how-do-i-change-the-
author-
of-a-commit-in-git


For the future, Scott and Pawel please double check your Gerrit
setup as per the instructions here:

http://wiki.eclipse.org/Development_Resources/Handling_Git_Contribu
ti
ons#Gerrit


If you don't find a problem, please file a bug against Eclipse
Community.
Preserving the Author is very important, and I'm pretty sure that
it usually works with Gerrit.

Thanks,
Martin

-----Original Message-----
From: tcf-dev-bounces@xxxxxxxxxxx
[mailto:tcf-dev-bounces@xxxxxxxxxxx]
On Behalf Of Pawel Piech
Sent: Tuesday, August 28, 2012 7:15 PM
To: tcf-dev@xxxxxxxxxxx
Subject: Re: [tcf-dev] tracking TCF contributions for IP log

FYI, I just found out that gerrit doesn't preserve contributor's
Author field when merging to the repo :-(  This means that to get
the correct IP log record, I have to add the iplog+ flag on the
while bug (since the patch is in gerrit).

See bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=388128.

Cheers,
Pawel

On 08/22/2012 01:21 AM, Oberhuber, Martin wrote:
Hi Pawel,

Just found this in my inbox (sorry for the delay) -

The default method of contribution tracking in git is the Author
field only
(no "iplog+" needed any more for things that you pull from a git repo).
You should check the generated IP log from time to time whether
your
recent contributions are actually in:
http://www.eclipse.org/projects/ip_log.php?projectid=tools.cdt.tc
f

If one is missing for any reason, please let us know and add the
respective
"iplog+" flag on bugzilla.
One extra feature that I personally like from CDT (and we don't
currently
have) is linking the bug with the git repo by means of
automatically adding the commit ID to the bug as a comment. This
is some confirmation that the link is actually correct and
sometimes helps tracking changes. I'm not sure how CDT does that,
does anyone else know ?
Martin


-----Original Message-----
From: tcf-dev-bounces@xxxxxxxxxxx
[mailto:tcf-dev-bounces@xxxxxxxxxxx]
On Behalf Of Pawel Piech
Sent: Tuesday, July 31, 2012 12:01 AM
To: TCF Development
Subject: [tcf-dev] tracking TCF contributions for IP log

Hi Martin,
Can you clarify for me what is our current method for tracking
contributions and generating the IP log?  Is it using the iplog+
flag in buzilla, using the Author field in git, or both?  If
it's the first, then I guess for any contributions done through
gerrit, we'll need to
attach them to the bug as well.
Thanks,
Pawel


_______________________________________________
tcf-dev mailing list
tcf-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/tcf-dev
_______________________________________________
tcf-dev mailing list
tcf-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/tcf-dev
_______________________________________________
tcf-dev mailing list
tcf-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/tcf-dev
_______________________________________________
tcf-dev mailing list
tcf-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/tcf-dev
_______________________________________________
tcf-dev mailing list
tcf-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/tcf-dev
_______________________________________________
tcf-dev mailing list
tcf-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/tcf-dev
_______________________________________________
tcf-dev mailing list
tcf-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/tcf-dev
_______________________________________________
tcf-dev mailing list
tcf-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/tcf-dev
_______________________________________________
tcf-dev mailing list
tcf-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/tcf-dev


Back to the top