Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [stp-dev] [Policy] Policy Editors integration

Hi Andrei,

(copied stp-dev in the interest of transparency)

Replies inline...

Andrei Shakirin wrote:
Hi David,

I find the screenshot basically ok, but from my point of view it make no sense to expand alternatives in XEF. Let show them collapsed and disabled and do not allow to expand them. In this case XEF will always show one flat policy hierarchy level (alternatives or/and assertions) - it is consistent and less confusing for the user. Working with hierarchy tree is functionality of WTP editor.
Ok, that's fair enough. I actually thought of that too. Because of the way things were hooked into the existing code, the tree came for free, but I can disable it at that point. I will do this in a subsequent commit.
Two additional notes:
1. If user clicks onto assertion, XEF editor will show all assertions in parent alternative, it is a good idea to select exactly this assertion in XEF Editor by default. WTP editor will prepare additional property "selection" with value XPath to selected assertion/alternative. Do you think it is possible to implement?
Yes, this would be a nice usability addition. I'm sure it can be implemented. It would be useful to create a unit test for this that exactly shows what the WTP editor will provide. I can then extend that unit test to ensure the XEF editor selects the right thing.
I've added this as a bug in bugzilla: 224066

2. By adding new assertion XEF opens new editor even if user cancels the schema selection dialog. Could you avoid opening editor in this case?
Good point too. Added bug 224067

Thanks for the feedback!

David

----------------------------
IONA Technologies PLC (registered in Ireland)
Registered Number: 171387
Registered Address: The IONA Building, Shelbourne Road, Dublin 4, Ireland

Back to the top